linux-kernel - Re: [PATCH] staging: r8188eu: remove forward declaration of Efuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202108211104.R2np9jK2-lkp@intel.com>
Date:   Sat, 21 Aug 2021 11:10:35 +0800
From:   kernel test robot <lkp@...el.com>
To:     Phillip Potter <phil@...lpotter.co.uk>, gregkh@...uxfoundation.org
Cc:     kbuild-all@...ts.01.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, martin@...ser.cx,
        straube.linux@...il.com, Larry.Finger@...inger.net
Subject: Re: [PATCH] staging: r8188eu: remove forward declaration of
 Efuse_Read1ByteFromFakeContent

Hi Phillip,

I love your patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Phillip-Potter/staging-r8188eu-remove-forward-declaration-of-Efuse_Read1ByteFromFakeContent/20210821-080835
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 093991aaadf0fbb34184fa37a46e7a157da3f386
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/195b942818ec8dcaa8f3ffd7e8c623d172d75a50
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Phillip-Potter/staging-r8188eu-remove-forward-declaration-of-Efuse_Read1ByteFromFakeContent/20210821-080835
        git checkout 195b942818ec8dcaa8f3ffd7e8c623d172d75a50
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/staging/r8188eu/core/rtw_efuse.c:33:1: warning: no previous prototype for 'Efuse_Read1ByteFromFakeContent' [-Wmissing-prototypes]
      33 | Efuse_Read1ByteFromFakeContent(
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
   Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
   Selected by
   - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
   - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC


vim +/Efuse_Read1ByteFromFakeContent +33 drivers/staging/r8188eu/core/rtw_efuse.c

15865124feed88 Phillip Potter 2021-07-28  27  
15865124feed88 Phillip Potter 2021-07-28  28  /*  */
15865124feed88 Phillip Potter 2021-07-28  29  #define REG_EFUSE_CTRL		0x0030
15865124feed88 Phillip Potter 2021-07-28  30  #define EFUSE_CTRL			REG_EFUSE_CTRL		/*  E-Fuse Control. */
15865124feed88 Phillip Potter 2021-07-28  31  /*  */
15865124feed88 Phillip Potter 2021-07-28  32  bool
15865124feed88 Phillip Potter 2021-07-28 @33  Efuse_Read1ByteFromFakeContent(
15865124feed88 Phillip Potter 2021-07-28  34  			struct adapter *pAdapter,
15865124feed88 Phillip Potter 2021-07-28  35  			u16 Offset,
15865124feed88 Phillip Potter 2021-07-28  36  		u8 *Value)
15865124feed88 Phillip Potter 2021-07-28  37  {
15865124feed88 Phillip Potter 2021-07-28  38  	if (Offset >= EFUSE_MAX_HW_SIZE)
15865124feed88 Phillip Potter 2021-07-28  39  		return false;
15865124feed88 Phillip Potter 2021-07-28  40  	if (fakeEfuseBank == 0)
15865124feed88 Phillip Potter 2021-07-28  41  		*Value = fakeEfuseContent[Offset];
15865124feed88 Phillip Potter 2021-07-28  42  	else
15865124feed88 Phillip Potter 2021-07-28  43  		*Value = fakeBTEfuseContent[fakeEfuseBank - 1][Offset];
15865124feed88 Phillip Potter 2021-07-28  44  	return true;
15865124feed88 Phillip Potter 2021-07-28  45  }
15865124feed88 Phillip Potter 2021-07-28  46  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (55027 bytes)