linux-kernel - Re: [PATCH] staging: r8188eu: core: remove condition with no effect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 22 Aug 2021 00:58:10 +0100
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     Saurav Girepunje <saurav.girepunje@...il.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Greg KH <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        saurav.girepunje@...mail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove condition with no effect

On Sat, 21 Aug 2021 at 21:23, Saurav Girepunje
<saurav.girepunje@...il.com> wrote:
>
> Remove the condition with no effect (if == else) in rtw_led.c
> file.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>
> ---
>  drivers/staging/r8188eu/core/rtw_led.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_led.c b/drivers/staging/r8188eu/core/rtw_led.c
> index 22d4df9c92a5..76cbd5f19f90 100644
> --- a/drivers/staging/r8188eu/core/rtw_led.c
> +++ b/drivers/staging/r8188eu/core/rtw_led.c
> @@ -148,10 +148,7 @@ static void SwLedBlink(struct LED_871x *pLed)
>                         _set_timer(&(pLed->BlinkTimer), LED_BLINK_SLOWLY_INTERVAL);
>                         break;
>                 case LED_BLINK_WPS:
> -                       if (pLed->BlinkingLedState == RTW_LED_ON)
> -                               _set_timer(&(pLed->BlinkTimer), LED_BLINK_LONG_INTERVAL);
> -                       else
> -                               _set_timer(&(pLed->BlinkTimer), LED_BLINK_LONG_INTERVAL);
> +                       _set_timer(&(pLed->BlinkTimer), LED_BLINK_LONG_INTERVAL);
>                         break;
>                 default:
>                         _set_timer(&(pLed->BlinkTimer), LED_BLINK_SLOWLY_INTERVAL);
> --
> 2.30.2
>

Thanks for this, looks good.

Acked-by: Phillip Potter <phil@...lpotter.co.uk>

Regards,
Phil