linux-kernel - [PATCH linux-next] ia64/kernel/iosapic: replace a printk + WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Aug 2021 20:44:16 -0700
From:   CGEL <cgel.zte@...il.com>
To:     inux-ia64@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        jing yangyang <jing.yangyang@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: [PATCH linux-next] ia64/kernel/iosapic: replace a printk + WARN_ON() to a WARN()

From: jing yangyang <jing.yangyang@....com.cn>

Replace a printk+WARN_ON() by a WARN(); this increases the chance of 
the string making it into the bugreport

This issue was detected with the help of Coccinelle.

Reported-by: Zeal Robot <zealci@....com.cn>
Signed-off-by: jing yangyang <jing.yangyang@....com.cn>
---
 arch/ia64/kernel/iosapic.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/arch/ia64/kernel/iosapic.c b/arch/ia64/kernel/iosapic.c
index 35adcf8..cb8ba1c 100644
--- a/arch/ia64/kernel/iosapic.c
+++ b/arch/ia64/kernel/iosapic.c
@@ -794,17 +794,13 @@ static inline unsigned char choose_dmode(void)
 	 */
 	irq = gsi_to_irq(gsi);
 	if (irq < 0) {
-		printk(KERN_ERR "iosapic_unregister_intr(%u) unbalanced\n",
-		       gsi);
-		WARN_ON(1);
+		WARN_ON(1, "iosapic_unregister_intr(%u) unbalanced\n", gsi);
 		return;
 	}
 
 	spin_lock_irqsave(&iosapic_lock, flags);
 	if ((rte = find_rte(irq, gsi)) == NULL) {
-		printk(KERN_ERR "iosapic_unregister_intr(%u) unbalanced\n",
-		       gsi);
-		WARN_ON(1);
+		WARN_ON(1, "iosapic_unregister_intr(%u) unbalanced\n", gsi);
 		goto out;
 	}
 
-- 
1.8.3.1