linux-kernel - Re: [kbuild] drivers/regulator/bd718x7-regulator.c:531:8: warning: Excessive padding in 'struct bd718xx_regulator_data' (8 padding bytes, where 0 is optimal).

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5cf8d0df-0fb7-5b91-53b2-9ceadbc23a7b@intel.com>
Date:   Sat, 21 Aug 2021 12:38:35 +0800
From:   kernel test robot <yujie.liu@...el.com>
To:     Mark Brown <broonie@...nel.org>
CC:     Matti Vaittinen <mazziesaccount@...il.com>,
        Cristian Marussi <cristian.marussi@....com>,
        <clang-built-linux@...glegroups.com>, <kbuild-all@...ts.01.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [kbuild] drivers/regulator/bd718x7-regulator.c:531:8: warning:
 Excessive padding in 'struct bd718xx_regulator_data' (8 padding bytes, where
 0 is optimal).

Hi Mark,

On 8/19/2021 11:23 PM, Mark Brown wrote:
> On Thu, Aug 19, 2021 at 10:49:13PM +0800, kernel test robot wrote:
> 
>> Sorry for bothering, we'll ignore struct padding warnings next time.
> 
> I think the warnings are useful, it's just that they're not important
> for all structs.  If the struct was getting allocated a lot it could be
> pointing out an issue that makes a real difference.  I'm not sure it s
> realistic for automation to figure it out for itself so it's better to
> send them even if they get ignored a lot.
> 

It's not very practical for automation to figure out how many copies of 
a struct would be created and how much space would be saved in total by 
adjusting struct padding.

For similar warnings in the future, we'll make an effort to do manual 
check first, and send out reports that we think are worthy of notice.

Best Regards,
Yujie Liu