linux-kernel - Re: [PATCH 02/10] staging: r8188eu: remove unused define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f98161a4-2065-d915-1d1e-04fbcf202e2d@gmail.com>
Date:   Sun, 22 Aug 2021 13:56:24 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Martin Kaiser <martin@...ser.cx>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/10] staging: r8188eu: remove unused define

On 8/21/21 6:48 PM, Martin Kaiser wrote:
> _HCI_OPS_OS_C_ is not used in the r8188eu driver. Remove it.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
>   drivers/staging/r8188eu/hal/usb_ops_linux.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c
> index 953fa05dc30c..a11a0597e515 100644
> --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c
> +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c
> @@ -1,8 +1,6 @@
>   // SPDX-License-Identifier: GPL-2.0
>   /* Copyright(c) 2007 - 2011 Realtek Corporation. */
>   
> -#define _HCI_OPS_OS_C_
> -
>   #include "../include/osdep_service.h"
>   #include "../include/drv_types.h"
>   #include "../include/osdep_intf.h"
> 

Looks good to me.

Acked-by: Michael Straube <straube.linux@...il.com>

Thanks,
Michael