linux-kernel - Re: [PATCH] staging: r8188eu: core: remove condition with no effect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 22 Aug 2021 14:36:11 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Saurav Girepunje <saurav.girepunje@...il.com>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Larry Finger <Larry.Finger@...inger.net>,
        linux-staging@...ts.linux.dev,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        saurav.girepunje@...mail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove condition with no effect

On Sun, Aug 22, 2021 at 01:06:09PM +0200, Fabio M. De Francesco wrote:
> On Sunday, August 22, 2021 1:58:10 AM CEST Phillip Potter wrote:
> > On Sat, 21 Aug 2021 at 21:23, Saurav Girepunje
> > 
> > <saurav.girepunje@...il.com> wrote:
> > > Remove the condition with no effect (if == else) in rtw_led.c
> > > file.
> > > 
> > > Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>
> > > ---
> > > 
> > >  drivers/staging/r8188eu/core/rtw_led.c | 5 +----
> > >  1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > Thanks for this, looks good.
> > 
> > Acked-by: Phillip Potter <phil@...lpotter.co.uk>
> > 
> > Regards,
> > Phil
> 
> Dear Philip,
> 
> Before acking, please check at least if it applies to the current version of 
> the tree and check if it compiles without adding warnings and / or errors. :-)

That is not necessary or needed here, I can do that when I apply the
patch.

greg k-h