linux-kernel - Re: [PATCH RFC 0/3] staging: r8188eu: avoid uninit value bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5d189b7-15b2-8cc3-1e84-021dc5ab51af@gmail.com>
Date:   Sun, 22 Aug 2021 15:50:35 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        straube.linux@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, Martin Kaiser <martin@...ser.cx>
Subject: Re: [PATCH RFC 0/3] staging: r8188eu: avoid uninit value bugs

On 8/22/21 3:39 PM, Greg KH wrote:
>> 
>> Yes, but _rtw_read*() == 0 indicates 2 states:
>> 
>> 	1. Error on transfer side
>> 	2. Actual register value is 0
> 
> That's not a good design, it should be fixed.  Note there is the new
> usb_control_msg_recv() function which should probably be used instead
> here, to prevent this problem from happening.
> 

Thank you, Greg, for confirmation. That's was the point why I started to 
write this series :)

I think, usb_control_msg_recv() won't help us with this problem, since 
all rtw_read*() functions return an unsigned value now. In future, when 
driver code will be fixed (ex: a lot of void function, which can fail 
and leave passed pointer uninitialized) we can move to new usb API and 
then move driver out of staging :)

With regards,
Pavel Skripkin