linux-kernel - Re: TODO list for staging/r8188eu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA=Fs0n9pJSRuC=LQ1WsSziaup8XsSax8cQAySb8jMHBQa4X0A@mail.gmail.com>
Date:   Sun, 22 Aug 2021 16:09:47 +0100
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        "open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
        open list <linux-kernel@...r.kernel.org>,
        Michael Straube <straube.linux@...il.com>,
        Martin Kaiser <martin@...ser.cx>
Subject: Re: TODO list for staging/r8188eu

On Sun, 22 Aug 2021 at 14:50, Fabio M. De Francesco
<fmdefrancesco@...il.com> wrote:
>
> On Sunday, August 22, 2021 2:36:57 PM CEST Greg Kroah-Hartman wrote:
> > On Sun, Aug 22, 2021 at 09:41:20AM +0200, Fabio M. De Francesco wrote:
> > > Dear Larry, Philip,
> > >
> > > >From what I understand how the development process works, drivers in
> staging
> > >
> > > should have a to-do list in the TODO file. Please read https://
> www.kernel.org/
> > > doc/html/latest/process/2.Process.html?highlight=todo#staging-trees.
> > >
> > > Could you (as the maintainers of the r8188eu driver) please compile and
> > > provide the above mentioned list?
> >
> > Why don't you provide an initial list for people to work off of if you
> > feel it is needed here?
> >
> > thanks,
> >
> > greg k-h
>
> Unfortunately I'm not able to tell what is needed to do to have a driver
> improved so that it can be moved off staging. This work should be better
> addressed by someone who is much more experienced.
>
> For example, I read from other drivers TODO lists that cfg80211 and lib80211
> are required but I don't know what they are.
>
> Regards,
>
> Fabio
>
>
>

Dear Fabio,

I believe Larry is working on hooking up CFG80211 again (he mentioned
going quite for a few days to work on it). As for other stuff that
needs doing, a few things come to mind:

* Removal of dead code (whether or not this includes the
debugging/printing macros is a matter of opinion, I would say yes
personally) such as unusued functions, struct fields, etc.
* Correction of code styling in the kernel (e.g. there is a lot of camel case).
* Use of in-kernel functionality and removal of unnecessary wrappers
where possible.
* Removal of the HAL layer and migration of its functionality into the
driver as a whole - this is an important one I would argue.

There is likely to be lots of other items not on that list, but that
would seem to be the basis of a TODO list if we need one?

Regards,
Phil