linux-kernel - Re: [PATCH] HSI: cmt_speech: unmark comments as kernel-doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210822171841.GA22647@duo.ucw.cz>
Date:   Sun, 22 Aug 2021 19:18:43 +0200
From:   Pavel Machek <pavel@....cz>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
        Sebastian Reichel <sre@...nel.org>,
        Aditya Srivastava <yashsri421@...il.com>,
        Kai Vehmanen <kai.vehmanen@...ia.com>
Subject: Re: [PATCH] HSI: cmt_speech: unmark comments as kernel-doc

On Sun 2021-08-22 09:38:38, Randy Dunlap wrote:
> Fix build warnings from the kernel test robot:
> 
> drivers/hsi/clients/cmt_speech.c:831: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>     * Block until pending data transfers have completed.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Sebastian Reichel <sre@...nel.org>
> Cc: Aditya Srivastava <yashsri421@...il.com>
> Cc: Kai Vehmanen <kai.vehmanen@...ia.com>

Acked-by: Pavel Machek <pavel@....cz>

Best regards,
								Pavel

> @@ -827,7 +827,7 @@ static int check_buf_params(struct cs_hs
>  	return r;
>  }
>  
> -/**
> +/*
>   * Block until pending data transfers have completed.
>   */
>  static int cs_hsi_data_sync(struct cs_hsi_iface *hi)
> @@ -850,7 +850,7 @@ static int cs_hsi_data_sync(struct cs_hs
>  			r = -ERESTARTSYS;
>  			goto out;
>  		}
> -		/**
> +		/*
>  		 * prepare_to_wait must be called with hi->lock held
>  		 * so that callbacks can check for waitqueue_active()
>  		 */

-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)