linux-kernel - Re: [PATCH] vsprintf and docs: Add X to %ph for upper case output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8afa5f3847a18ab15005614903646da822c1267a.camel@perches.com>
Date:   Sun, 22 Aug 2021 01:57:04 -0700
From:   Joe Perches <joe@...ches.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Jonathan Corbet <corbet@....net>,
        Linux Documentation List <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vsprintf and docs: Add X to %ph for upper case output

On Sun, 2021-08-22 at 11:53 +0300, Andy Shevchenko wrote:
> On Sun, Aug 22, 2021 at 11:45 AM Joe Perches <joe@...ches.com> wrote:
> > On Sun, 2021-08-22 at 11:31 +0300, Andy Shevchenko wrote:
> > > On Sun, Aug 22, 2021 at 6:00 AM Joe Perches <joe@...ches.com> wrote:
> > > > 
> > > > Uppercase hex output of small char arrays is moderately frequently used.
> > > > Add a mechanism to support the %*ph output as uppercase using 'X'.
> > > 
> > > Besides the fact of existing hex_asc_upper_*(), what ABI (!) uses
> > > this? If none, I dunno we need this.
> > > And show at least a few users where we gain something after conversion.
> > > 
> > 
> > There are at least a few uses that could be converted.
> 
> Provide a series then!
> 
> ...
> 
> > +       return snprintf(buf, 16 * 2 + 2, "%16phNX\n", sn);
> 
> > +       return scnprintf(buffer, PAGE_SIZE, "%16phNX\n", unique_id);
> 
> I think you need to convert to sysfs_emit() in both cases.

First things first...