linux-kernel - Re: [PATCH] staging: r8188eu: remove 5 GHz code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA=Fs0ks04VYJ56znpX2BjZX_7GCa=hkK+8TwifB_LwCry+y7g@mail.gmail.com>
Date:   Mon, 23 Aug 2021 22:30:09 +0100
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     Michael Straube <straube.linux@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Martin Kaiser <martin@...ser.cx>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        "open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: r8188eu: remove 5 GHz code

On Mon, 23 Aug 2021 at 20:31, Michael Straube <straube.linux@...il.com> wrote:
>
> The driver is for chips that do not operate in the 5 GHz band.
> Remove some 5 GHz related code.
>
> Signed-off-by: Michael Straube <straube.linux@...il.com>
> ---
>  drivers/staging/r8188eu/os_dep/ioctl_linux.c | 30 ++++++--------------
>  1 file changed, 8 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> index ab4a9200f079..81d4255d1785 100644
> --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> @@ -208,17 +208,10 @@ static char *translate_scan(struct adapter *padapter,
>                 else
>                         snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bg");
>         } else {
> -               if (pnetwork->network.Configuration.DSConfig > 14) {
> -                       if (ht_cap)
> -                               snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11an");
> -                       else
> -                               snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11a");
> -               } else {
> -                       if (ht_cap)
> -                               snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11gn");
> -                       else
> -                               snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11g");
> -               }
> +               if (ht_cap)
> +                       snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11gn");
> +               else
> +                       snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11g");
>         }
>
>         start = iwe_stream_add_event(info, start, stop, &iwe, IW_EV_CHAR_LEN);
> @@ -737,17 +730,10 @@ static int rtw_wx_get_name(struct net_device *dev,
>                         else
>                                 snprintf(wrqu->name, IFNAMSIZ, "IEEE 802.11bg");
>                 } else {
> -                       if (pcur_bss->Configuration.DSConfig > 14) {
> -                               if (ht_cap)
> -                                       snprintf(wrqu->name, IFNAMSIZ, "IEEE 802.11an");
> -                               else
> -                                       snprintf(wrqu->name, IFNAMSIZ, "IEEE 802.11a");
> -                       } else {
> -                               if (ht_cap)
> -                                       snprintf(wrqu->name, IFNAMSIZ, "IEEE 802.11gn");
> -                               else
> -                                       snprintf(wrqu->name, IFNAMSIZ, "IEEE 802.11g");
> -                       }
> +                       if (ht_cap)
> +                               snprintf(wrqu->name, IFNAMSIZ, "IEEE 802.11gn");
> +                       else
> +                               snprintf(wrqu->name, IFNAMSIZ, "IEEE 802.11g");
>                 }
>         } else {
>                 snprintf(wrqu->name, IFNAMSIZ, "unassociated");
> --
> 2.32.0
>

Dear Michael,

Looks good to me. Thanks.

Acked-by: Phillip Potter <phil@...lpotter.co.uk>

Regards,
Phil