linux-kernel - Re: [PATCH] staging: r8188eu: remove ip.h header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA=Fs0=46RNFVBphJb+yj8KRKsMfePRu21bAB+puTntSF7ayFA@mail.gmail.com>
Date:   Mon, 23 Aug 2021 23:38:01 +0100
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     Michael Straube <straube.linux@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Martin Kaiser <martin@...ser.cx>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        "open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: r8188eu: remove ip.h header file

On Mon, 23 Aug 2021 at 23:32, Michael Straube <straube.linux@...il.com> wrote:
>
> On 8/24/21 12:21 AM, Phillip Potter wrote:
> > On Mon, 23 Aug 2021 at 09:19, Michael Straube <straube.linux@...il.com> wrote:
> >>
> >> The struct ip_options declared in ip.h is only unsed in the optlength
> >> macro which is also defined in ip.h. All other definitions/declarations
> >> in ip.h are duplicated from <include/uapi/linux/ip.h>. Remove the ip.h
> >> header file and its includes.
> >>
> >> Signed-off-by: Michael Straube <straube.linux@...il.com>
> >> ---
>
> >
> > Dear Michael,
> >
> > Thanks for the patch. Sorry, but it seems to conflict with your
> > earlier patch titled: "[PATCH] staging: r8188eu: remove if_ether.h
> > header file". They apply fine individually, but not together - can you
> > confirm this is the case for you as well and not just me?
> >
> > Regards,
> > Phil
> >
>
> Hi Phillip,
>
> yes I can confirm, sorry about that. I will rework and send both patches
> in a series. Thank you for testing and pointing out this conflict.
>
> best regards,
> Michael

No apology necessary, and thanks again for the patches.

Regards,
Phil