linux-kernel - Re: [PATCH] iio: adc128s052: Fix the error handling path of 'adc128

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+U=DsoTdb3b+LJEtUagKr=LmK8E2M_2yhtNDENKsczqGaUPYA@mail.gmail.com>
Date:   Mon, 23 Aug 2021 09:42:23 +0300
From:   Alexandru Ardelean <ardeleanalex@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        angelo.compagnucci@...il.com,
        linux-iio <linux-iio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] iio: adc128s052: Fix the error handling path of 'adc128_probe()'

On Sat, Aug 21, 2021 at 1:43 PM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> A successful 'regulator_enable()' call should be balanced by a
> corresponding 'regulator_disable()' call in the error handling path of the
> probe, as already done in the remove function.
>
> Update the error handling path accordingly.

Good catch.
For the fix:

Reviewed-by: Alexandru Ardelean <ardeleanalex@...il.com>

If you want, you can also send a conversion to
devm_iio_device_register() for this driver.
And also move the regulator_disable() on a devm_add_action_or_reset() callback.
Maybe, that's already part of your plan. If so, apologies for the noise :)


>
> Fixes: 913b86468674 ("iio: adc: Add TI ADC128S052")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/iio/adc/ti-adc128s052.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c
> index 3143f35a6509..83c1ae07b3e9 100644
> --- a/drivers/iio/adc/ti-adc128s052.c
> +++ b/drivers/iio/adc/ti-adc128s052.c
> @@ -171,7 +171,13 @@ static int adc128_probe(struct spi_device *spi)
>         mutex_init(&adc->lock);
>
>         ret = iio_device_register(indio_dev);
> +       if (ret)
> +               goto err_disable_regulator;
>
> +       return 0;
> +
> +err_disable_regulator:
> +       regulator_disable(adc->reg);
>         return ret;
>  }
>
> --
> 2.30.2
>