linux-kernel - Re: [PATCH] crypto: ccp: shutdown SEV firmware on kexec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YSNPKPPjEFxGT0Dc@xanadu.blop.info>
Date:   Mon, 23 Aug 2021 09:32:56 +0200
From:   Lucas Nussbaum <lucas.nussbaum@...ia.fr>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Brijesh Singh <brijesh.singh@....com>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...nel.org, Tom Lendacky <thomas.lendacky@....com>,
        Joerg Roedel <jroedel@...e.de>,
        David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH] crypto: ccp: shutdown SEV firmware on kexec

On 06/08/21 at 20:14 +0800, Herbert Xu wrote:
> On Wed, Jul 28, 2021 at 10:15:21AM -0500, Brijesh Singh wrote:
> > The commit 97f9ac3db6612 ("crypto: ccp - Add support for SEV-ES to the
> > PSP driver") added support to allocate Trusted Memory Region (TMR)
> > used during the SEV-ES firmware initialization. The TMR gets locked
> > during the firmware initialization and unlocked during the shutdown.
> > While the TMR is locked, access to it is disallowed.
> > 
> > Currently, the CCP driver does not shutdown the firmware during the
> > kexec reboot, leaving the TMR memory locked.
> > 
> > Register a callback to shutdown the SEV firmware on the kexec boot.
> > 
> > Fixes: 97f9ac3db6612 ("crypto: ccp - Add support for SEV-ES to the PSP driver")
> > Reported-by: Lucas Nussbaum <lucas.nussbaum@...ia.fr>
> > Tested-by: Lucas Nussbaum <lucas.nussbaum@...ia.fr>
> > Cc: <stable@...nel.org>
> > Cc: Tom Lendacky <thomas.lendacky@....com>
> > Cc: Joerg Roedel <jroedel@...e.de>
> > Cc: Herbert Xu <herbert@...dor.apana.org.au>
> > Cc: David Rientjes <rientjes@...gle.com>
> > Signed-off-by: Brijesh Singh <brijesh.singh@....com>
> > ---
> >  drivers/crypto/ccp/sev-dev.c | 49 +++++++++++++++++-------------------
> >  drivers/crypto/ccp/sp-pci.c  | 12 +++++++++
> >  2 files changed, 35 insertions(+), 26 deletions(-)
> 
> Patch applied.  Thanks.

Could this be backported to 5.10 as well?

Thanks
-- 
Lucas Nussbaum   <lucas.nussbaum@...ia.fr>   +33 3 54 95 86 19
Responsable du programme plateformes d'expérimentation
DDO-SDT - Direction Générale Déléguée à l'Innovation - Inria