linux-kernel - Re: [PATCH v2] media: camss: vfe: Don't call hw_version() before its dependencies are met

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Aug 2021 12:10:19 +0200
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Robert Foss <robert.foss@...aro.org>, todor.too@...il.com,
        agross@...nel.org, bjorn.andersson@...aro.org, mchehab@...nel.org,
        hverkuil-cisco@...all.nl, linux-media@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Naresh Kamboju <naresh.kamboju@...aro.org>
Cc:     Linux Kernel Functional Testing <lkft@...aro.org>
Subject: Re: [PATCH v2] media: camss: vfe: Don't call hw_version() before
 its dependencies are met

On 12.08.2021 12:16, Marek Szyprowski wrote:
> On 12.08.2021 11:21, Robert Foss wrote:
>> vfe->ops->hw_version(vfe) is being called before vfe->base has been
>> assigned, and before the hardware has been powered up.
>>
>> Fixes: b10b5334528a9 ("media: camss: vfe: Don't read hardware version 
>> needlessly")
>>
>> Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
>> Reported-by: Marek Szyprowski <m.szyprowski@...sung.com>
>> Signed-off-by: Robert Foss <robert.foss@...aro.org>
> Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>

This restores old, well tested code path.

Reviewed-by: Marek Szyprowski <m.szyprowski@...sung.com>

>> ---
>>   drivers/media/platform/qcom/camss/camss-vfe.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c 
>> b/drivers/media/platform/qcom/camss/camss-vfe.c
>> index 6b2f33fc9be2..71f78b40e7f5 100644
>> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
>> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
>> @@ -604,6 +604,8 @@ static int vfe_get(struct vfe_device *vfe)
>>           vfe_reset_output_maps(vfe);
>>             vfe_init_outputs(vfe);
>> +
>> +        vfe->ops->hw_version(vfe);
>>       } else {
>>           ret = vfe_check_clock_rates(vfe);
>>           if (ret < 0)
>> @@ -1299,7 +1301,6 @@ int msm_vfe_subdev_init(struct camss *camss, 
>> struct vfe_device *vfe,
>>           return -EINVAL;
>>       }
>>       vfe->ops->subdev_init(dev, vfe);
>> -    vfe->ops->hw_version(vfe);
>>         /* Memory */
>
> Best regards

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland