linux-kernel - Re: [PATCH] checkpatch: Improve GIT_COMMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <79330fbb1ac84c8c489c8495b4ff34cc5b446c0c.camel@perches.com>
Date:   Mon, 23 Aug 2021 03:35:48 -0700
From:   Joe Perches <joe@...ches.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Andy Whitcroft <apw@...onical.com>,
        Dwaipayan Ray <dwaipayanray1@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Denis Efremov <efremov@...ux.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Improve GIT_COMMIT_ID test

On Sun, 2021-08-22 at 15:03 -0700, Andrew Morton wrote:
> On Fri, 20 Aug 2021 14:46:51 -0700 Joe Perches <joe@...ches.com> wrote:
> 
> > +		if ($perl_version_ok
> > +		    $in_commit_log && !$commit_log_possible_stack_dump &&
> 
> Needs &&.   Was the correct version sent?

Yes, but I stuffed up the && around the perl_version_ok test
I added at the last minute.

oops.