linux-kernel - Re: [PATCH linux-next] serial: drop unneeded assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <16e64194-452f-bac8-c535-df9dd65048c7@kernel.org>
Date:   Mon, 23 Aug 2021 12:40:30 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     CGEL <cgel.zte@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, Luo penghao <luo.penghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] serial: drop unneeded assignment

One more hint:
$ git log --oneline  drivers/tty/nozomi.c|grep -i serial
<empty>

Please use some of already used "tty: nozomi:", "tty/nozomi:", or "tty: 
nozomi," prefixes for the subject.

On 21. 08. 21, 4:17, CGEL wrote:
> From: Luo penghao <luo.penghao@....com.cn>
> 
> The first assignment is not used. In order to keep the code style
> consistency of the whole file, the first 'offset' assignment should be
> deleted.
> 
> The clang_analyzer complains as follows:
> 
> drivers/tty/nozomi.c:520:6: warning:
> Although the value storedto 'offset' is used in the enclosing expression,
> the value is never actually read from 'offset'.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Luo penghao <luo.penghao@....com.cn>
> ---
>   drivers/tty/nozomi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c
> index 0454c78..210a48f 100644
> --- a/drivers/tty/nozomi.c
> +++ b/drivers/tty/nozomi.c
> @@ -517,7 +517,7 @@ static void nozomi_setup_memory(struct nozomi *dc)
>   
>   	/* Ctrl dl configuration */
>   	dc->port[PORT_CTRL].dl_addr[CH_A] =
> -				(offset += dc->config_table.dl_app2_len);
> +				(offset + dc->config_table.dl_app2_len);
>   	dc->port[PORT_CTRL].dl_size[CH_A] =
>   				dc->config_table.dl_ctrl_len - buff_offset;
>   
> 


-- 
js