linux-kernel - [PATCH] dio: add missing iounmap() after ioremap()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <202108232045471583580@zte.com.cn>
Date:   Mon, 23 Aug 2021 20:45:47 +0800 (CST)
From:   <yang.yang29@....com.cn>
To:     <gregkh@...uxfoundation.org>, <salah.triki@...il.com>
Cc:     <linux-kernel@...r.kernel.org>, <xu.xin16@....com.cn>,
        <yang.yang29@....com.cn>
Subject: [PATCH] dio: add missing iounmap() after ioremap()

From: xu xin <xu.xin16@....com.cn>

If kzalloc() fails, the 'va' needs to be unmapped before returning -ENOMEM.

Reported-by: Zeal Robot <zealci@....com.cn>
Signed-off-by: xu xin <xu.xin16@....com.cn>
---
 drivers/dio/dio.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/dio/dio.c b/drivers/dio/dio.c
index 4c06c93..7d19250 100644
--- a/drivers/dio/dio.c
+++ b/drivers/dio/dio.c
@@ -218,9 +218,11 @@ static int __init dio_init(void)

        /* Found a board, allocate it an entry in the list */
        dev = kzalloc(sizeof(struct dio_dev), GFP_KERNEL);
-       if (!dev)
+       if (!dev) {
+           if (scode >= DIOII_SCBASE)
+               iounmap(va);
            return -ENOMEM;
+       }
        dev->bus = &dio_bus;
        dev->dev.parent = &dio_bus.dev;
        dev->dev.bus = &dio_bus_type;
-- 
2.15.2