linux-kernel - Re: [PATCH 3/3] can: mscan: mpc5xxx_can: Useof_device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eafd35fd-bf71-167a-b1c8-50e3117e4be4@cmss.chinamobile.com>
Date:   Mon, 23 Aug 2021 21:52:03 +0800
From:   tangbin <tangbin@...s.chinamobile.com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
Cc:     davem@...emloft.net, wg@...ndegger.com, kuba@...nel.org,
        kevinbrace@...cecomputerlab.com, romieu@...zoreil.com,
        linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] can: mscan: mpc5xxx_can: Useof_device_get_match_data
 to simplify code

Hi Marc:

On 2021/8/23 20:37, Marc Kleine-Budde wrote:
> On 23.08.2021 19:33:38, Tang Bin wrote:
>> Retrieve OF match data, it's better and cleaner to use
>> 'of_device_get_match_data' over 'of_match_device'.
>>
>> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
> Thanks for the patch!
>
> LGTM, comment inside.
>
>> ---
>>   drivers/net/can/mscan/mpc5xxx_can.c | 6 ++----
>>   1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can/mscan/mpc5xxx_can.c
>> index e254e04ae..3b7465acd 100644
>> --- a/drivers/net/can/mscan/mpc5xxx_can.c
>> +++ b/drivers/net/can/mscan/mpc5xxx_can.c
>> @@ -279,7 +279,6 @@ static u32 mpc512x_can_get_clock(struct platform_device *ofdev,
>>   static const struct of_device_id mpc5xxx_can_table[];
>>   static int mpc5xxx_can_probe(struct platform_device *ofdev)
>>   {
>> -	const struct of_device_id *match;
>>   	const struct mpc5xxx_can_data *data;
>>   	struct device_node *np = ofdev->dev.of_node;
>>   	struct net_device *dev;
>> @@ -289,10 +288,9 @@ static int mpc5xxx_can_probe(struct platform_device *ofdev)
>>   	int irq, mscan_clksrc = 0;
>>   	int err = -ENOMEM;
>>   
>> -	match = of_match_device(mpc5xxx_can_table, &ofdev->dev);
>> -	if (!match)
>> +	data = of_device_get_match_data(&ofdev->dev);
>> +	if (!data)
>>   		return -EINVAL;
> Please remove the "BUG_ON(!data)", which comes later.

For this place, may I send another patch to fix this 'BUG_ON()' by 
itself, not in this patch series?

Thanks

Tang Bin

>
>> -	data = match->data;
>>   
>>   	base = of_iomap(np, 0);
>>   	if (!base) {
>> -- 
>> 2.20.1.windows.1
>>
>>
>>
>>
> regards,
> Marc
>