lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YSPw5B0Njj3sUdKB@slm.duckdns.org>
Date:   Mon, 23 Aug 2021 09:03:00 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Daniel Jordan <daniel.m.jordan@...cle.com>
Cc:     Huaixin Chang <changhuaixin@...ux.alibaba.com>,
        linux-kernel@...r.kernel.org, peterz@...radead.org,
        anderson@...unc.edu, baruah@...tl.edu, bsegall@...gle.com,
        dietmar.eggemann@....com, dtcccc@...ux.alibaba.com,
        juri.lelli@...hat.com, khlebnikov@...dex-team.ru,
        luca.abeni@...tannapisa.it, mgorman@...e.de, mingo@...hat.com,
        odin@...d.al, odin@...dal.com, pauld@...head.com, pjt@...gle.com,
        rostedt@...dmis.org, shanpeic@...ux.alibaba.com,
        tommaso.cucinotta@...tannapisa.it, vincent.guittot@...aro.org,
        xiyou.wangcong@...il.com
Subject: Re: [PATCH 1/2] sched/fair: Add cfs bandwidth burst statistics

On Mon, Aug 23, 2021 at 02:32:10PM -0400, Daniel Jordan wrote:
> burst_time is nsec, not usec.
> 
> Just "burst_time" seems the way to go for consistency with
> throttled_time in the same file, though "burst_usec" nicely has units
> and would have the same name between cgroup1 and 2.

The cgroup2 interface rule is that time units are in usecs. The right thing
to do is keeping the _usec postfix (to avoid confusion due to the unit
change from cgroup1) and converting it to usecs for printing.

Thanks.

-- 
tejun

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ