linux-kernel - RE: [PATCH] drm/amd/pm: And destination bounds checking to struct copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BL1PR12MB514453053481613D46D64470F7C49@BL1PR12MB5144.namprd12.prod.outlook.com>
Date:   Mon, 23 Aug 2021 19:13:43 +0000
From:   "Deucher, Alexander" <Alexander.Deucher@....com>
To:     "Koenig, Christian" <Christian.Koenig@....com>,
        Kees Cook <keescook@...omium.org>,
        "Lazar, Lijo" <Lijo.Lazar@....com>
CC:     "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        "Zhang, Hawking" <Hawking.Zhang@....com>,
        "Xu, Feifei" <Feifei.Xu@....com>, "Gao, Likun" <Likun.Gao@....com>,
        "Gu, JiaWei (Will)" <JiaWei.Gu@....com>,
        "Quan, Evan" <Evan.Quan@....com>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "Tuikov, Luben" <Luben.Tuikov@....com>,
        "Grodzovsky, Andrey" <Andrey.Grodzovsky@....com>,
        "Li, Dennis" <Dennis.Li@....com>,
        "Sundararaju, Sathishkumar" <Sathishkumar.Sundararaju@....com>,
        "Kim, Jonathan" <Jonathan.Kim@....com>,
        "Wang, Kevin(Yang)" <Kevin1.Wang@....com>,
        "Nieto, David M" <David.Nieto@....com>,
        "Feng, Kenneth" <Kenneth.Feng@....com>,
        Lee Jones <lee.jones@...aro.org>,
        "Clements, John" <John.Clements@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>
Subject: RE: [PATCH] drm/amd/pm: And destination bounds checking to struct
 copy

[Public]

> -----Original Message-----
> From: Koenig, Christian <Christian.Koenig@....com>
> Sent: Monday, August 23, 2021 3:02 PM
> To: Kees Cook <keescook@...omium.org>; Lazar, Lijo
> <Lijo.Lazar@....com>
> Cc: Pan, Xinhui <Xinhui.Pan@....com>; David Airlie <airlied@...ux.ie>;
> Daniel Vetter <daniel@...ll.ch>; Zhang, Hawking
> <Hawking.Zhang@....com>; Xu, Feifei <Feifei.Xu@....com>; Gao, Likun
> <Likun.Gao@....com>; Gu, JiaWei (Will) <JiaWei.Gu@....com>; Quan,
> Evan <Evan.Quan@....com>; amd-gfx@...ts.freedesktop.org; dri-
> devel@...ts.freedesktop.org; Deucher, Alexander
> <Alexander.Deucher@....com>; Tuikov, Luben
> <Luben.Tuikov@....com>; Grodzovsky, Andrey
> <Andrey.Grodzovsky@....com>; Li, Dennis <Dennis.Li@....com>;
> Sundararaju, Sathishkumar <Sathishkumar.Sundararaju@....com>; Kim,
> Jonathan <Jonathan.Kim@....com>; Wang, Kevin(Yang)
> <Kevin1.Wang@....com>; Nieto, David M <David.Nieto@....com>; Feng,
> Kenneth <Kenneth.Feng@....com>; Lee Jones <lee.jones@...aro.org>;
> Clements, John <John.Clements@....com>; linux-kernel@...r.kernel.org;
> linux-hardening@...r.kernel.org
> Subject: Re: [PATCH] drm/amd/pm: And destination bounds checking to
> struct copy
> 
> Am 23.08.21 um 16:23 schrieb Kees Cook:
> >
> > On August 22, 2021 11:28:54 PM PDT, "Christian König"
> <christian.koenig@....com> wrote:
> >>
> >> Am 19.08.21 um 22:14 schrieb Kees Cook:
> >>> [...]
> >>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> >>> b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> >>> index 96e895d6be35..4605934a4fb7 100644
> >>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> >>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> >>> @@ -1446,4 +1446,29 @@ static inline int amdgpu_in_reset(struct
> amdgpu_device *adev)
> >>>    {
> >>>    	return atomic_read(&adev->in_gpu_reset);
> >>>    }
> >>> +
> >>> +/**
> >>> + * memcpy_trailing - Copy the end of one structure into the middle
> >>> +of another
> >>> + *
> >>> + * @dst: Pointer to destination struct
> >>> + * @first_dst_member: The member name in @dst where the
> overwrite
> >>> +begins
> >>> + * @last_dst_member: The member name in @dst where the
> overwrite
> >>> +ends after
> >>> + * @src: Pointer to the source struct
> >>> + * @first_src_member: The member name in @src where the copy
> begins
> >>> + *
> >>> + */
> >>> +#define memcpy_trailing(dst, first_dst_member, last_dst_member,
> 		   \
> >>> +		        src, first_src_member)				   \
> >> Please don't add a function like this into amdgpu.h, especially when
> >> it is only used by the SMU code.
> > Sure, I'm happy to move it. It wasn't clear to me which headers were
> considered "immutable". Which header should I put this in?
> 
> I think amdgpu_smuio.h, but I'm not 100% sure. Alex do you have a better
> idea?
> 

No, that's for the SMUIO callbacks for the IP block.  Please use drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h

Alex

> We don't want to put anything new into amdgpu.h any more since this is
> basically only a legacy leftover.
> 
> Thanks,
> Christian.
> 
> >
> >> And please give it an amdgpu_ prefix so that we are not confusing it
> >> with a core function.
> > Sure, I will include that.
> >
> >> Apart from that looks good to me.
> > Thanks!
> >
> > -Kees