linux-kernel - Re: [PATCH] staging: r8188eu: make rtw_deinit_intf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Aug 2021 21:34:33 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Pavel Skripkin <paskripkin@...il.com>, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, gregkh@...uxfoundation.org
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: make rtw_deinit_intf_priv return void

On 8/23/21 8:40 PM, Pavel Skripkin wrote:
> rtw_deinit_intf_priv() always return success, so there is no need in
> return value
> 
> Signed-off-by: Pavel Skripkin <paskripkin@...il.com>
> ---
>   drivers/staging/r8188eu/os_dep/usb_intf.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
> index e002070f7fba..37694aa96d13 100644
> --- a/drivers/staging/r8188eu/os_dep/usb_intf.c
> +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
> @@ -129,13 +129,10 @@ static u8 rtw_init_intf_priv(struct dvobj_priv *dvobj)
>   	return rst;
>   }
>   
> -static u8 rtw_deinit_intf_priv(struct dvobj_priv *dvobj)
> +static void rtw_deinit_intf_priv(struct dvobj_priv *dvobj)
>   {
> -	u8 rst = _SUCCESS;
> -
>   	kfree(dvobj->usb_alloc_vendor_req_buf);
>   	_rtw_mutex_free(&dvobj->usb_vendor_req_mutex);
> -	return rst;
>   }
>   
>   static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)
> 

Looks good to me, thanks.

Acked-by: Michael Straube <straube.linux@...il.com>