linux-kernel - Re: [PATCH] [v2] ASoC: Intel: sof_rt5682: Add support for max98390 speaker amp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c0e98e24-1c62-aa37-e283-c8b5f56f4f2e@linux.intel.com>
Date:   Tue, 24 Aug 2021 11:22:09 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Mark Hsieh <mark_hsieh@...tron.corp-partner.google.com>,
        alsa-devel@...a-project.org
Cc:     cezary.rojewski@...el.com, kai.vehmanen@...ux.intel.com,
        mac.chiang@...el.com, lance.hou@...el.com, broonie@...nel.org,
        brent.lu@...el.com, bard.liao@...el.com,
        liam.r.girdwood@...ux.intel.com, yang.jie@...ux.intel.com,
        perex@...ex.cz, linux-kernel@...r.kernel.org,
        mark_hsieh@...tron.com
Subject: Re: [PATCH] [v2] ASoC: Intel: sof_rt5682: Add support for max98390
 speaker amp

Looks mostly good, minor comments below

On 8/24/21 8:21 AM, Mark Hsieh wrote:
> Configure adl_max98390_rt5682 to support the rt5682 headset codec and max98390 speaker
> 
> BUG=b:191811888
> TEST=emerge-brya chromeos-kernel-5_10

I don't think we need this for upstream?

> +struct snd_soc_ops max_98390_ops = {
> +	.hw_params = max_98390_hw_params,
> +};

this could be const. We didn't do it for previous codecs but that was a
miss. I'll send a patch for the max98373

> +extern struct snd_soc_ops max_98390_ops;

const