linux-kernel - Re: sound/soc/sof/intel/hda-dai.c:265:22: warning: Value stored to 'sdev' during its initialization is never read [clang-analyzer-deadcode.DeadStores]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77ba5fc1-2bfa-0e9f-525c-dc260642c7ab@linux.intel.com>
Date:   Tue, 24 Aug 2021 11:40:20 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     kernel test robot <lkp@...el.com>
Cc:     clang-built-linux@...glegroups.com, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, Takashi Iwai <tiwai@...e.de>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>,
        Bard Liao <bard.liao@...el.com>
Subject: Re: sound/soc/sof/intel/hda-dai.c:265:22: warning: Value stored to
 'sdev' during its initialization is never read
 [clang-analyzer-deadcode.DeadStores]

Thanks for the report, I am not sure it's a real issue?
>>> sound/soc/sof/intel/hda-dai.c:265:22: warning: Value stored to 'sdev' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
>            struct snd_sof_dev *sdev =
>                                ^~~~
>    sound/soc/sof/intel/hda-dai.c:265:22: note: Value stored to 'sdev' during its initialization is never read
>            struct snd_sof_dev *sdev =
>                                ^~~~
> fdd961e37e47f2 Keyon Jie         2019-04-12  259  
> fdd961e37e47f2 Keyon Jie         2019-04-12  260  static int hda_link_pcm_prepare(struct snd_pcm_substream *substream,
> fdd961e37e47f2 Keyon Jie         2019-04-12  261  				struct snd_soc_dai *dai)
> fdd961e37e47f2 Keyon Jie         2019-04-12  262  {
> ed3baacd76baa0 Ranjani Sridharan 2019-04-30  263  	struct hdac_ext_stream *link_dev =
> ed3baacd76baa0 Ranjani Sridharan 2019-04-30  264  				snd_soc_dai_get_dma_data(dai, substream);
> fdd961e37e47f2 Keyon Jie         2019-04-12 @265  	struct snd_sof_dev *sdev =
> fdd961e37e47f2 Keyon Jie         2019-04-12  266  				snd_soc_component_get_drvdata(dai->component);
> 1205300af9dba3 Kuninori Morimoto 2020-07-20  267  	struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
> fdd961e37e47f2 Keyon Jie         2019-04-12  268  	int stream = substream->stream;
> fdd961e37e47f2 Keyon Jie         2019-04-12  269  
> a3ebccb52efdfb Kai Vehmanen      2019-07-22  270  	if (link_dev->link_prepared)
> fdd961e37e47f2 Keyon Jie         2019-04-12  271  		return 0;
> fdd961e37e47f2 Keyon Jie         2019-04-12  272  
> ed3baacd76baa0 Ranjani Sridharan 2019-04-30  273  	dev_dbg(sdev->dev, "hda: prepare stream dir %d\n", substream->stream);
> fdd961e37e47f2 Keyon Jie         2019-04-12  274  
> fdd961e37e47f2 Keyon Jie         2019-04-12  275  	return hda_link_hw_params(substream, &rtd->dpcm[stream].hw_params,
> fdd961e37e47f2 Keyon Jie         2019-04-12  276  				  dai);
> fdd961e37e47f2 Keyon Jie         2019-04-12  277  }
> fdd961e37e47f2 Keyon Jie         2019-04-12  278  

The sdev variable is used in the dev_dbg() log, this looks legit to me?