linux-kernel - Re: [PATCH] x86/kdump: fix wrong judge about crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <88a2ca7b-9335-33c4-37f7-8f0de2c56114@linux.alibaba.com>
Date:   Tue, 24 Aug 2021 10:31:28 +0800
From:   Xin Hao <xhao@...ux.alibaba.com>
To:     tglx@...utronix.de
Cc:     mingo@...hat.com, bp@...en8.de, hpa@...or.com, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/kdump: fix wrong judge about crash_size var

Hi,  everyone:

     Why nobody review this patch?

在 2021/8/13 下午3:12, Xin Hao 写道:
> The type of crash_size is unsigned long long, so
> it can not be less than 0, so there fix it.
>
> Signed-off-by: Xin Hao <xhao@...ux.alibaba.com>
> ---
>   arch/x86/kernel/setup.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index bff3a784aec5..95b80ec11741 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -472,11 +472,11 @@ static void __init reserve_crashkernel(void)
>
>   	/* crashkernel=XM */
>   	ret = parse_crashkernel(boot_command_line, total_mem, &crash_size, &crash_base);
> -	if (ret != 0 || crash_size <= 0) {
> +	if (ret != 0 || !crash_size) {
>   		/* crashkernel=X,high */
>   		ret = parse_crashkernel_high(boot_command_line, total_mem,
>   					     &crash_size, &crash_base);
> -		if (ret != 0 || crash_size <= 0)
> +		if (ret != 0 || !crash_size)
>   			return;
>   		high = true;
>   	}
> --
> 2.31.0

-- 
Best Regards!
Xin Hao