linux-kernel - Re: [PATCH 5.10 10/98] vdpa: Define vdpa mgmt device, ops and a netlink interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210824185452.GA15995@duo.ucw.cz>
Date:   Tue, 24 Aug 2021 20:54:52 +0200
From:   Pavel Machek <pavel@....cz>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Parav Pandit <parav@...dia.com>, Eli Cohen <elic@...dia.com>,
        Jason Wang <jasowang@...hat.com>,
        "Michael S . Tsirkin" <mst@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        syzbot <syzkaller@...glegroups.com>
Subject: Re: [PATCH 5.10 10/98] vdpa: Define vdpa mgmt device, ops and a
 netlink interface

Hi!

> From: Parav Pandit <parav@...dia.com>
> 
> [ Upstream commit 33b347503f014ebf76257327cbc7001c6b721956 ]
> 
> To add one or more VDPA devices, define a management device which
> allows adding or removing vdpa device. A management device defines
> set of callbacks to manage vdpa devices.
> 
> To begin with, it defines add and remove callbacks through which a user
> defined vdpa device can be added or removed.

This looks quite intrusive; is it meant to be in -stable, or is it
some kind of mistake?

Best regards,
									Pavel
									

> Signed-off-by: Parav Pandit <parav@...dia.com>
> Reviewed-by: Eli Cohen <elic@...dia.com>
> Reviewed-by: Jason Wang <jasowang@...hat.com>
> Link: https://lore.kernel.org/r/20210105103203.82508-4-parav@nvidia.com
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> 
> Including a bugfix:
> 
> vpda: correctly size vdpa_nl_policy
> 
> We need to ensure last entry of vdpa_nl_policy[]
> is zero, otherwise out-of-bounds access is hurting us.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>
> Cc: Parav Pandit <parav@...dia.com>
> Cc: Eli Cohen <elic@...dia.com>
> Cc: Jason Wang <jasowang@...hat.com>
> Cc: Michael S. Tsirkin <mst@...hat.com>
> Link: https://lore.kernel.org/r/20210210134911.4119555-1-eric.dumazet@gmail.com
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  drivers/vdpa/Kconfig      |   1 +
>  drivers/vdpa/vdpa.c       | 213 +++++++++++++++++++++++++++++++++++++-
>  include/linux/vdpa.h      |  31 ++++++
>  include/uapi/linux/vdpa.h |  31 ++++++
>  4 files changed, 275 insertions(+), 1 deletion(-)
>  create mode 100644 include/uapi/linux/vdpa.h

-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)