linux-kernel - RE: [RFC] Make use of non-dynamic dmabuf in RDMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB45482FF79156A2509E4DDDEBE5C59@DM6PR11MB4548.namprd11.prod.outlook.com>
Date:   Tue, 24 Aug 2021 20:00:27 +0000
From:   "Xiong, Jianxin" <jianxin.xiong@...el.com>
To:     Alex Deucher <alexdeucher@...il.com>,
        Dave Airlie <airlied@...il.com>
CC:     John Hubbard <jhubbard@...dia.com>, Jason Gunthorpe <jgg@...pe.ca>,
        Christian König <christian.koenig@....com>,
        Gal Pressman <galpress@...zon.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Doug Ledford <dledford@...hat.com>,
        "open list:DMA BUFFER SHARING FRAMEWORK" 
        <linux-media@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        "Gabbay, Oded (Habana)" <ogabbay@...ana.ai>,
        "Tayar, Tomer (Habana)" <ttayar@...ana.ai>,
        Yossi Leybovich <sleybo@...zon.com>,
        "Alexander Matushevsky" <matua@...zon.com>,
        Leon Romanovsky <leonro@...dia.com>
Subject: RE: [RFC] Make use of non-dynamic dmabuf in RDMA

> -----Original Message-----
> From: Alex Deucher <alexdeucher@...il.com>
> Sent: Tuesday, August 24, 2021 12:44 PM
> To: Dave Airlie <airlied@...il.com>
> Cc: John Hubbard <jhubbard@...dia.com>; Jason Gunthorpe <jgg@...pe.ca>; Christian König <christian.koenig@....com>; Gal Pressman
> <galpress@...zon.com>; Daniel Vetter <daniel@...ll.ch>; Sumit Semwal <sumit.semwal@...aro.org>; Doug Ledford
> <dledford@...hat.com>; open list:DMA BUFFER SHARING FRAMEWORK <linux-media@...r.kernel.org>; dri-devel <dri-
> devel@...ts.freedesktop.org>; Linux Kernel Mailing List <linux-kernel@...r.kernel.org>; linux-rdma <linux-rdma@...r.kernel.org>; Gabbay,
> Oded (Habana) <ogabbay@...ana.ai>; Tayar, Tomer (Habana) <ttayar@...ana.ai>; Yossi Leybovich <sleybo@...zon.com>; Alexander
> Matushevsky <matua@...zon.com>; Leon Romanovsky <leonro@...dia.com>; Xiong, Jianxin <jianxin.xiong@...el.com>
> Subject: Re: [RFC] Make use of non-dynamic dmabuf in RDMA
> 
> On Tue, Aug 24, 2021 at 3:16 PM Dave Airlie <airlied@...il.com> wrote:
> >
> > On Wed, 25 Aug 2021 at 03:36, John Hubbard <jhubbard@...dia.com> wrote:
> > >
> > > On 8/24/21 10:32 AM, Jason Gunthorpe wrote:
> > > ...
> > > >>> And yes at least for the amdgpu driver we migrate the memory to
> > > >>> host memory as soon as it is pinned and I would expect that
> > > >>> other GPU drivers do something similar.
> > > >>
> > > >> Well...for many topologies, migrating to host memory will result
> > > >> in a dramatically slower p2p setup. For that reason, some GPU
> > > >> drivers may want to allow pinning of video memory in some situations.
> > > >>
> > > >> Ideally, you've got modern ODP devices and you don't even need to pin.
> > > >> But if not, and you still hope to do high performance p2p between
> > > >> a GPU and a non-ODP Infiniband device, then you would need to
> > > >> leave the pinned memory in vidmem.
> > > >>
> > > >> So I think we don't want to rule out that behavior, right? Or is
> > > >> the thinking more like, "you're lucky that this old non-ODP setup
> > > >> works at all, and we'll make it work by routing through host/cpu
> > > >> memory, but it will be slow"?
> > > >
> > > > I think it depends on the user, if the user creates memory which
> > > > is permanently located on the GPU then it should be pinnable in
> > > > this way without force migration. But if the memory is inherently
> > > > migratable then it just cannot be pinned in the GPU at all as we
> > > > can't indefinately block migration from happening eg if the CPU
> > > > touches it later or something.
> > > >
> > >
> > > OK. I just want to avoid creating any API-level assumptions that
> > > dma_buf_pin() necessarily implies or requires migrating to host memory.
> >
> > I'm not sure we should be allowing dma_buf_pin at all on
> > non-migratable memory, what's to stop someone just pinning all the
> > VRAM and making the GPU unuseable?
> 
> In a lot of cases we have GPUs with more VRAM than system memory, but we allow pinning in system memory.
> 
> Alex
> 

In addition, the dma-buf exporter can be a non-GPU device.

Jianxin

> >
> > I understand not considering more than a single user in these
> > situations is enterprise thinking, but I do worry about pinning is
> > always fine type of thinking when things are shared or multi-user.
> >
> > My impression from this is we've designed hardware that didn't
> > consider the problem, and now to let us use that hardware in horrible
> > ways we should just allow it to pin all the things.
> >
> > Dave.