linux-kernel - Re: [PATCH linux-next] r8188eu: remove unneeded conversions to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Aug 2021 23:02:00 +0100
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     CGEL <cgel.zte@...il.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Straube <straube.linux@...il.com>,
        "open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jing Yangyang <jing.yangyang@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] r8188eu: remove unneeded conversions to bool

On Tue, 24 Aug 2021 at 07:34, CGEL <cgel.zte@...il.com> wrote:
>
> From: Jing Yangyang <jing.yangyang@....com.cn>
>
> Found with scripts/coccinelle/misc/boolconv.cocci.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Jing Yangyang <jing.yangyang@....com.cn>
> ---
>  drivers/staging/r8188eu/core/rtw_mlme_ext.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> index 5325fe4..20dc4d4 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> @@ -3758,7 +3758,7 @@ int issue_probereq_p2p_ex(struct adapter *adapter, u8 *da, int try_cnt, int wait
>         u32 start = jiffies;
>
>         do {
> -               ret = _issue_probereq_p2p(adapter, da, wait_ms > 0 ? true : false);
> +               ret = _issue_probereq_p2p(adapter, da, wait_ms > 0);
>
>                 i++;
>
> @@ -4890,7 +4890,7 @@ int issue_probereq_ex(struct adapter *padapter, struct ndis_802_11_ssid *pssid,
>         u32 start = jiffies;
>
>         do {
> -               ret = _issue_probereq(padapter, pssid, da, wait_ms > 0 ? true : false);
> +               ret = _issue_probereq(padapter, pssid, da, wait_ms > 0);
>
>                 i++;
>
> @@ -5605,7 +5605,7 @@ int issue_nulldata(struct adapter *padapter, unsigned char *da, unsigned int pow
>                 da = get_my_bssid(&pmlmeinfo->network);
>
>         do {
> -               ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0 ? true : false);
> +               ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0);
>
>                 i++;
>
> @@ -5728,7 +5728,7 @@ int issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16 tid, int
>                 da = get_my_bssid(&pmlmeinfo->network);
>
>         do {
> -               ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0 ? true : false);
> +               ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0);
>
>                 i++;
>
> @@ -5839,7 +5839,7 @@ int issue_deauth_ex(struct adapter *padapter, u8 *da, unsigned short reason, int
>         u32 start = jiffies;
>
>         do {
> -               ret = _issue_deauth(padapter, da, reason, wait_ms > 0 ? true : false);
> +               ret = _issue_deauth(padapter, da, reason, wait_ms > 0);
>
>                 i++;
>
> --
> 1.8.3.1
>
>

Not had time to buildest/run this, but it looks ok to me. Many thanks.

Acked-by: Phillip Potter <phil@...lpotter.co.uk>

Regards,
Phil