linux-kernel - 5.14-rc breaks iotop swap io monitoring.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Aug 2021 23:16:48 -0400
From:   Dave Jones <davej@...emonkey.org.uk>
To:     Linux Kernel <linux-kernel@...r.kernel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: 5.14-rc breaks iotop swap io monitoring.

I just noticed that in 5.14-rc running iotop, it complains on startup
that "CONFIG_TASK_DELAY_ACCT not enabled in kernel, cannot determine
SWAPIN and IO %" and sure enough a bunch of columns show up as
'unavailable'.

My suspicion is this commit, which I've not confirmed yet as it doesn't
cleanly revert.  I'll poke at it some more in the morning, but figured
I'd bring it up sans-evidence in the hope that I'll wake up to someone
having an Ah-ha moment.

	Dave


commit c5895d3f06cbb80ccb311f1dcb37074651030cb6
Author: Peter Zijlstra <peterz@...radead.org>
Date:   Tue May 4 22:43:42 2021 +0200

    sched: Simplify sched_info_on()
    
    The situation around sched_info is somewhat complicated, it is used by
    sched_stats and delayacct and, indirectly, kvm.
    
    If SCHEDSTATS=Y (but disabled by default) sched_info_on() is
    unconditionally true -- this is the case for all distro kernel configs
    I checked.
    
    If for some reason SCHEDSTATS=N, but TASK_DELAY_ACCT=Y, then
    sched_info_on() can return false when delayacct is disabled,
    presumably because there would be no other users left; except kvm is.
    
    Instead of complicating matters further by accurately accounting
    sched_stat and kvm state, simply unconditionally enable when
    SCHED_INFO=Y, matching the common distro case.
    
    Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
    Reviewed-by: Thomas Gleixner <tglx@...utronix.de>
    Reviewed-by: Ingo Molnar <mingo@...nel.org>
    Acked-by: Johannes Weiner <hannes@...xchg.org>
    Link: https://lkml.kernel.org/r/20210505111525.121458839@infradead.org