linux-kernel - Re: [PATCH linux-next] arm:nommu: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <328bbb63-f8a6-2c50-2264-1fd404ff1f9d@arm.com>
Date:   Tue, 24 Aug 2021 09:25:39 +0100
From:   Vladimir Murzin <vladimir.murzin@....com>
To:     CGEL <cgel.zte@...il.com>, Russell King <linux@...linux.org.uk>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Ira Weiny <ira.weiny@...el.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Jing Yangyang <jing.yangyang@....com.cn>,
        Zeal Robot <zealci@....com.cn>, denghuilong@...rlc.com
Subject: Re: [PATCH linux-next] arm:nommu: fix boolreturn.cocci warnings

On 8/24/21 5:11 AM, CGEL wrote:
> From: Jing Yangyang <jing.yangyang@....com.cn>
> 
> ./arch/arm/mm/nommu.c:59:8-9:WARNING:return of 0/1 in function
> 'security_extensions_enabled' with return type bool
> 
> Return statements in functions returning bool should use true/false
> instead of 1/0.
> 
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Jing Yangyang <jing.yangyang@....com.cn>
> ---
>  arch/arm/mm/nommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mm/nommu.c b/arch/arm/mm/nommu.c
> index 2658f52..7256ac1 100644
> --- a/arch/arm/mm/nommu.c
> +++ b/arch/arm/mm/nommu.c
> @@ -56,7 +56,7 @@ static inline bool security_extensions_enabled(void)
>  	if ((read_cpuid_id() & 0x000f0000) == 0x000f0000)
>  		return cpuid_feature_extract(CPUID_EXT_PFR1, 4) ||
>  			cpuid_feature_extract(CPUID_EXT_PFR1, 20);
> -	return 0;
> +	return false;
>  }
>  
>  unsigned long setup_vectors_base(void)
> 

The same patch was sent before [1] by Huilong Deng. It was reviewed
and author was advised to submit it into RMK's Patch system.  


[1] https://lore.kernel.org/linux-arm-kernel/1e30b659-a91a-58f6-f9aa-d0f0259eb9e8@arm.com/T/#t

Cheers
Vladimir