linux-kernel - Re: [PATCH linux-next] kernel:fair: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210824094128.58898319@oasis.local.home>
Date:   Tue, 24 Aug 2021 09:41:28 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     CGEL <cgel.zte@...il.com>, Ingo Molnar <mingo@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        linux-kernel@...r.kernel.org,
        Jing Yangyang <jing.yangyang@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] kernel:fair: fix boolreturn.cocci warnings

On Tue, 24 Aug 2021 10:22:49 +0200
Peter Zijlstra <peterz@...radead.org> wrote:

> On Tue, Aug 24, 2021 at 10:15:54AM +0200, Peter Zijlstra wrote:
> > On Mon, Aug 23, 2021 at 11:23:59PM -0700, CGEL wrote:  
> > > From: Jing Yangyang <jing.yangyang@....com.cn>
> > > 
> > > ./kernel/sched/fair.c:9638:9-10:WARNING: return of 0/1 in function
> > > 'imbalanced_active_balance' with return type bool
> > > 
> > > Return statements in functions returning bool should use true/false
> > > instead of 1/0.
> > > 
> > > Generated by: scripts/coccinelle/misc/boolreturn.cocci
> > > 
> > > Reported-by: Zeal Robot <zealci@....com.cn>
> > > Signed-off-by: Jing Yangyang <jing.yangyang@....com.cn>  
> > 
> > *sigh*, another stupid robot sending stupid patches..
> > 
> > /me goes create another mail filter...  
> 
> Here, the hunk of sieve script, incase other people want to use it too.
> 
> 
> #SCRIPTNAME: Zeal Robot
> if body :text :contains "Reported-by: Zeal Robot <zealci@....com.cn>"
> {
>     fileinto "SPAM";
>     stop;
> }

Doesn't hurt to just take the patch and then you wont have to spend
time on new robots flagging this as a "bug".

-- Steve