linux-kernel - Re: [PATCH] drm/amdgpu: Fix build with missing pm_suspend_target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1bb0baef-7924-98ab-b125-aa3c2ac405d4@amd.com>
Date:   Tue, 24 Aug 2021 19:22:46 +0530
From:   "Lazar, Lijo" <lijo.lazar@....com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Alex Deucher <alexdeucher@...il.com>,
        Alex Deucher <alexander.deucher@....com>,
        Pratik Vishwakarma <Pratik.Vishwakarma@....com>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amdgpu: Fix build with missing
 pm_suspend_target_state module export



On 8/24/2021 7:10 PM, Borislav Petkov wrote:
> On Tue, Aug 24, 2021 at 06:38:41PM +0530, Lazar, Lijo wrote:
>> Without CONFIG_PM_SLEEP and with CONFIG_SUSPEND
> 
> Can you even create such a .config?

The description of  "(drm/amdgpu: fix checking pmops when PM_SLEEP is 
not enabled)" says -


'pm_suspend_target_state' is only available when CONFIG_PM_SLEEP
is set/enabled. OTOH, when both SUSPEND and HIBERNATION are not set,
PM_SLEEP is not set, so this variable cannot be used.

../drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c: In function 
‘amdgpu_acpi_is_s0ix_active’:
../drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:1046:11: error: 
‘pm_suspend_target_state’ undeclared (first use in this function); did 
you mean ‘__KSYM_pm_suspend_target_state’?
     return pm_suspend_target_state == PM_SUSPEND_TO_IDLE;
            ^~~~~~~~~~~~~~~~~~~~~~~
            __KSYM_pm_suspend_target_state

Also use shorter IS_ENABLED(CONFIG_foo) notation for checking the
2 config symbols.

So it does look like that error can be extracted as well in some config.

> 
>> I remember giving a reviewed-by for this one, looks like it never got in.
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.spinics.net%2Flists%2Famd-gfx%2Fmsg66166.html&amp;data=04%7C01%7Clijo.lazar%40amd.com%7C4d61b17225944c45335b08d967049ee6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637654091831465201%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=GCdVG8N7g2E9DaiM1ek1voKQ9stZNfnEwyghQ0pWoxU%3D&amp;reserved=0
> 
> A better version of that one got in:
> 
> 5706cb3c910c ("drm/amdgpu: fix checking pmops when PM_SLEEP is not enabled")
> 

Well, now it doesn't seem to be a better one. The original one checked both.

Thanks,
Lijo