linux-kernel - Re: [PATCH linux-next] tools:signal: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16561a4f-6043-cc5b-7a50-5be1ff10bfa5@linuxfoundation.org>
Date:   Tue, 24 Aug 2021 08:39:10 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     CGEL <cgel.zte@...il.com>,
        Catalin Marinas <catalin.marinas@....com>
Cc:     Will Deacon <will@...nel.org>, Shuah Khan <shuah@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jing Yangyang <jing.yangyang@....com.cn>,
        Zeal Robot <zealci@....com.cn>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH linux-next] tools:signal: fix boolreturn.cocci warnings

On 8/24/21 12:51 AM, CGEL wrote:
> From: Jing Yangyang <jing.yangyang@....com.cn>
> 
> ./tools/testing/selftests/arm64/signal/test_signals_utils.h:112:9-10
> WARNING: return of 0/1 in function 'get_current_context' with
> return type bool
> 
> Return statements in functions returning bool should use true/false
> instead of 1/0.
> 
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Jing Yangyang <jing.yangyang@....com.cn>
> ---
>   tools/testing/selftests/arm64/signal/test_signals_utils.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/arm64/signal/test_signals_utils.h b/tools/testing/selftests/arm64/signal/test_signals_utils.h
> index 6772b5c..66122e6 100644
> --- a/tools/testing/selftests/arm64/signal/test_signals_utils.h
> +++ b/tools/testing/selftests/arm64/signal/test_signals_utils.h
> @@ -109,7 +109,7 @@ static __always_inline bool get_current_context(struct tdescr *td,
>   	if (seen_already) {
>   		fprintf(stdout,
>   			"Unexpected successful sigreturn detected: live_uc is stale !\n");
> -		return 0;
> +		return false;
>   	}
>   	seen_already = 1;
>   
> 

We can't accept this patch. The from and Signed-off-by don't match.

thanks,
-- Shuah