linux-kernel - Re: [PATCH linux-next] tools: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Aug 2021 08:39:56 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     cgel.zte@...il.com, jasowang@...hat.com
Cc:     john.stultz@...aro.org, tglx@...utronix.de, sboyd@...nel.org,
        shuah@...nel.org, mst@...hat.com, zhang.yunkai@....com.cn,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        virtualization@...ts.linux-foundation.org,
        Zeal Robot <zealci@....com.cn>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH linux-next] tools: remove unneeded semicolon

On 8/2/21 1:14 AM, cgel.zte@...il.com wrote:
> From: Zhang Yunkai <zhang.yunkai@....com.cn>
> 
> Fix the following coccicheck REVIEW:
> ./tools/testing/selftests/timers/inconsistency-check.c:75:2-3 REVIEW
> Unneeded semicolon
> ./tools/testing/selftests/timers/set-timer-lat.c:83:2-3 REVIEW Unneeded
> semicolon
> ./tools/virtio/virtio-trace/trace-agent-ctl.c:78:2-3 REVIEW Unneeded
> semicolon
> ./tools/testing/selftests/timers/nanosleep.c:75:2-3 REVIEW Unneeded
> semicolon
> ./tools/testing/selftests/timers/nsleep-lat.c:75:2-3 REVIEW Unneeded
> semicolon
> ./tools/testing/selftests/timers/alarmtimer-suspend.c:82:2-3 REVIEW
> Unneeded semicolon
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Zhang Yunkai <zhang.yunkai@....com.cn>
> ---
>   tools/testing/selftests/timers/alarmtimer-suspend.c  | 2 +-
>   tools/testing/selftests/timers/inconsistency-check.c | 2 +-
>   tools/testing/selftests/timers/nanosleep.c           | 2 +-
>   tools/testing/selftests/timers/nsleep-lat.c          | 2 +-
>   tools/testing/selftests/timers/set-timer-lat.c       | 2 +-
>   tools/virtio/virtio-trace/trace-agent-ctl.c          | 2 +-
>   6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/testing/selftests/timers/alarmtimer-suspend.c b/tools/testing/selftests/timers/alarmtimer-suspend.c
> index 4da09dbf83ba..54da4b088f4c 100644
> --- a/tools/testing/selftests/timers/alarmtimer-suspend.c
> +++ b/tools/testing/selftests/timers/alarmtimer-suspend.c
> @@ -79,7 +79,7 @@ char *clockstring(int clockid)
>   		return "CLOCK_BOOTTIME_ALARM";
>   	case CLOCK_TAI:
>   		return "CLOCK_TAI";
> -	};
> +	}
>   	return "UNKNOWN_CLOCKID";
>   }
>   
> diff --git a/tools/testing/selftests/timers/inconsistency-check.c b/tools/testing/selftests/timers/inconsistency-check.c
> index 022d3ffe3fbf..e6756d9c60a7 100644
> --- a/tools/testing/selftests/timers/inconsistency-check.c
> +++ b/tools/testing/selftests/timers/inconsistency-check.c
> @@ -72,7 +72,7 @@ char *clockstring(int clockid)
>   		return "CLOCK_BOOTTIME_ALARM";
>   	case CLOCK_TAI:
>   		return "CLOCK_TAI";
> -	};
> +	}
>   	return "UNKNOWN_CLOCKID";
>   }
>   
> diff --git a/tools/testing/selftests/timers/nanosleep.c b/tools/testing/selftests/timers/nanosleep.c
> index 71b5441c2fd9..433a09676aeb 100644
> --- a/tools/testing/selftests/timers/nanosleep.c
> +++ b/tools/testing/selftests/timers/nanosleep.c
> @@ -72,7 +72,7 @@ char *clockstring(int clockid)
>   		return "CLOCK_BOOTTIME_ALARM";
>   	case CLOCK_TAI:
>   		return "CLOCK_TAI";
> -	};
> +	}
>   	return "UNKNOWN_CLOCKID";
>   }
>   
> diff --git a/tools/testing/selftests/timers/nsleep-lat.c b/tools/testing/selftests/timers/nsleep-lat.c
> index eb3e79ed7b4a..a7ca9825e106 100644
> --- a/tools/testing/selftests/timers/nsleep-lat.c
> +++ b/tools/testing/selftests/timers/nsleep-lat.c
> @@ -72,7 +72,7 @@ char *clockstring(int clockid)
>   		return "CLOCK_BOOTTIME_ALARM";
>   	case CLOCK_TAI:
>   		return "CLOCK_TAI";
> -	};
> +	}
>   	return "UNKNOWN_CLOCKID";
>   }
>   
> diff --git a/tools/testing/selftests/timers/set-timer-lat.c b/tools/testing/selftests/timers/set-timer-lat.c
> index 50da45437daa..d60bbcad487f 100644
> --- a/tools/testing/selftests/timers/set-timer-lat.c
> +++ b/tools/testing/selftests/timers/set-timer-lat.c
> @@ -80,7 +80,7 @@ char *clockstring(int clockid)
>   		return "CLOCK_BOOTTIME_ALARM";
>   	case CLOCK_TAI:
>   		return "CLOCK_TAI";
> -	};
> +	}
>   	return "UNKNOWN_CLOCKID";
>   }
>   
> diff --git a/tools/virtio/virtio-trace/trace-agent-ctl.c b/tools/virtio/virtio-trace/trace-agent-ctl.c
> index 73d253d4b559..39860be6e2d8 100644
> --- a/tools/virtio/virtio-trace/trace-agent-ctl.c
> +++ b/tools/virtio/virtio-trace/trace-agent-ctl.c
> @@ -75,7 +75,7 @@ static int wait_order(int ctl_fd)
>   
>   		if (ret)
>   			break;
> -	};
> +	}
>   
>   	return ret;
>   
> 

We can't accept this patch. The from and Signed-off-by don't match.

thanks,
-- Shuah