linux-kernel - Re: [PATCH linux-next] testing/vm/: fix application of sizeof to pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <76e5e569-0c43-241d-bdfa-5a8da79574b8@linuxfoundation.org>
Date:   Tue, 24 Aug 2021 08:40:34 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     CGEL <cgel.zte@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Shuah Khan <shuah@...nel.org>, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        jing yangyang <jing.yangyang@....com.cn>,
        Zeal Robot <zealci@....com.cn>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH linux-next] testing/vm/: fix application of sizeof to
 pointer

On 8/19/21 9:24 PM, CGEL wrote:
> From: jing yangyang <jing.yangyang@....com.cn>
> 
> sizeof when applied to a pointer typed expression gives the size of the
> pointer.
> 
> ./tools/testing/selftests/vm/split_huge_page_test.c:344:36-42: ERROR application
> of sizeof to pointer
> 
> This issue was detected with the help of Coccinelle.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: jing yangyang <jing.yangyang@....com.cn>
> ---
>   tools/testing/selftests/vm/split_huge_page_test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/vm/split_huge_page_test.c b/tools/testing/selftests/vm/split_huge_page_test.c
> index 1af16d2..54bf57f 100644
> --- a/tools/testing/selftests/vm/split_huge_page_test.c
> +++ b/tools/testing/selftests/vm/split_huge_page_test.c
> @@ -341,7 +341,7 @@ void split_file_backed_thp(void)
>   	}
>   
>   	/* write something to the file, so a file-backed THP can be allocated */
> -	num_written = write(fd, tmpfs_loc, sizeof(tmpfs_loc));
> +	num_written = write(fd, tmpfs_loc, sizeof(*tmpfs_loc));
>   	close(fd);
>   
>   	if (num_written < 1) {
> 

We can't accept this patch. The from and Signed-off-by don't match.

thanks,
-- Shuah