linux-kernel - Re: [PATCH] selinux: remove duplicated initialization of 'i' for clean-up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhTgeSbRDrK-HHaZLxyR7ezFrW-0TbGRfutF1NwXVHnXWg@mail.gmail.com>
Date:   Tue, 24 Aug 2021 10:46:31 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Austin Kim <austindh.kim@...il.com>
Cc:     Stephen Smalley <stephen.smalley.work@...il.com>,
        Eric Paris <eparis@...isplace.org>, selinux@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-team@....com,
        austin.kim@....com
Subject: Re: [PATCH] selinux: remove duplicated initialization of 'i' for clean-up

On Mon, Aug 23, 2021 at 10:22 PM Austin Kim <austindh.kim@...il.com> wrote:
>
> From: Austin Kim <austin.kim@....com>
>
> The local variable 'i' is used to be incremented inside while loop
> within sidtab_convert_tree(). Before while loop, 'i' is set to 0
> inside if/else statement.
>
> Since there is no 'goto' statement within sidtab_convert_tree(),
> it had better initialize 'i' as 0 once before if/else statement.
>
> Signed-off-by: Austin Kim <austin.kim@....com>
> ---
>  security/selinux/ss/sidtab.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Let's leave the existing code as-is for now.

-- 
paul moore
www.paul-moore.com