linux-kernel - Re: [PATCH linux-next] x86:uv: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YSUT9S+uD8KyaqgR@swahl-home.5wahls.com>
Date:   Tue, 24 Aug 2021 10:44:53 -0500
From:   Steve Wahl <steve.wahl@....com>
To:     CGEL <cgel.zte@...il.com>
Cc:     Steve Wahl <steve.wahl@....com>, Mike Travis <mike.travis@....com>,
        Dimitri Sivanich <dimitri.sivanich@....com>,
        Russ Anderson <russ.anderson@....com>,
        Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
        linux-kernel@...r.kernel.org,
        Jing Yangyang <jing.yangyang@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] x86:uv: fix boolreturn.cocci warnings

Reviewed-by: Steve Wahl <steve.wahl@....com>

On Tue, Aug 24, 2021 at 12:21:24AM -0700, CGEL wrote:
> From: Jing Yangyang <jing.yangyang@....com.cn>
> 
> ./arch/x86/include/asm/uv/uv.h:36:53-54:WARNING:return of 0/1 in
> function 'is_early_uv_system' with return type bool
> 
> Return statements in functions returning bool should use true/false
> instead of 1/0.
> 
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Jing Yangyang <jing.yangyang@....com.cn>
> ---
>  arch/x86/include/asm/uv/uv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/uv/uv.h b/arch/x86/include/asm/uv/uv.h
> index 648eb23..9395925 100644
> --- a/arch/x86/include/asm/uv/uv.h
> +++ b/arch/x86/include/asm/uv/uv.h
> @@ -33,7 +33,7 @@ static inline bool is_early_uv_system(void)
>  #else	/* !X86_UV */
>  
>  static inline enum uv_system_type get_uv_system_type(void) { return UV_NONE; }
> -static inline bool is_early_uv_system(void)	{ return 0; }
> +static inline bool is_early_uv_system(void)	{ return false; }
>  static inline int is_uv_system(void)	{ return 0; }
>  static inline int is_uv_hubbed(int uv)	{ return 0; }
>  static inline void uv_cpu_init(void)	{ }
> -- 
> 1.8.3.1
> 
> 

-- 
Steve Wahl, Hewlett Packard Enterprise