linux-kernel - Re: [PATCH 4.19.y] net: dsa: mt7530: disable learning on standalone ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALW65ja3hYGmEqcWZzifP2-0WsJOnxcUXsey2ZH5vDbD0-nDeQ@mail.gmail.com>
Date:   Tue, 24 Aug 2021 23:57:53 +0800
From:   DENG Qingfang <dqfext@...il.com>
To:     Sasha Levin <sashal@...nel.org>
Cc:     stable@...r.kernel.org, Sean Wang <sean.wang@...iatek.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "open list:MEDIATEK SWITCH DRIVER" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH 4.19.y] net: dsa: mt7530: disable learning on standalone ports

Hi Sasha,

On Tue, Aug 24, 2021 at 11:29 PM Sasha Levin <sashal@...nel.org> wrote:
> What's the reasoning behind:
>
> 1. Backporting this patch?

Standalone ports should have address learning disabled, according to
the documentation:
https://www.kernel.org/doc/html/v5.14-rc7/networking/dsa/dsa.html#bridge-layer
dsa_switch_ops on 5.10 or earlier does not have .port_bridge_flags
function so it has to be done differently.

I've identified an issue related to this.

> 2. A partial backport of this patch?

The other part does not actually fix anything.

>
> --
> Thanks,
> Sasha