linux-kernel - Re: [PATCH] x86/sgx: Add SGX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e0522fa59b2029d6a2210c1113919b572746f794.camel@kernel.org>
Date:   Tue, 24 Aug 2021 04:16:11 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Dave Hansen <dave.hansen@...el.com>, linux-sgx@...r.kernel.org
Cc:     Shuah Khan <shuah@...nel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
        Jonathan Corbet <corbet@....net>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mike Rapoport <rppt@...nel.org>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Saravanan D <saravanand@...com>,
        "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>,
        Krish Sadhukhan <krish.sadhukhan@...cle.com>,
        linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH] x86/sgx: Add SGX_MemTotal to /proc/meminfo

On Mon, 2021-08-23 at 08:15 -0700, Dave Hansen wrote:
> On 8/18/21 6:25 AM, Jarkko Sakkinen wrote:
> > The amount of SGX memory on the system is determined by the BIOS and it
> > varies wildly between systems.  It can be from dozens of MB's on desktops
> > or VM's, up to many GB's on servers.  Just like for regular memory, it is
> > sometimes useful to know the amount of usable SGX memory in the system.
> > 
> > Add SGX_MemTotal field to /proc/meminfo, which shows the total amount of
> > usable SGX memory in the system.  E.g. with 32 MB reserved for SGX from
> > BIOS, the printout would be:
> > 
> > SGX_MemTotal:      22528 kB
> 
> The big question here: Do we want to put purely architecture-specific
> entries in (the currently quite arch-independent) /proc/meminfo?
> 
> The current "DirectMap4k/2M/1G" entries from arch_report_meminfo() are
> arch-specific in their sizes, of course, but the concept is at least
> quite arch-independent.

I started with /proc/meminfo instead of /sys/devices/system/node/*/meminfo
because there is pre-existing arch callback, and secondary because it's also
better fit for my kselftest code.

The same discussion still applies to both files, they probably should follow a
matching pattern.

/Jarkko