linux-kernel - Re: [PATCH linux-next] selftests/powerpc: remove duplicate include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Aug 2021 10:42:19 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Christophe Leroy <christophe.leroy@...roup.eu>,
        CGEL <cgel.zte@...il.com>, Michael Ellerman <mpe@...erman.id.au>
Cc:     Zeal Robot <zealci@....com.cn>, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org, Paul Mackerras <paulus@...ba.org>,
        linux-kselftest@...r.kernel.org,
        Changcheng Deng <deng.changcheng@....com.cn>,
        Shuah Khan <shuah@...nel.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH linux-next] selftests/powerpc: remove duplicate include

On 8/24/21 10:35 AM, Christophe Leroy wrote:
> 
> 
> Le 24/08/2021 à 16:41, Shuah Khan a écrit :
>> On 8/23/21 9:05 PM, CGEL wrote:
>>> From: Changcheng Deng <deng.changcheng@....com.cn>
>>>
>>> Clean up the following includecheck warning:
>>>
>>> ./tools/testing/selftests/powerpc/tm/tm-poison.c: inttypes.h is included
>>> more than once.
>>>
>>> No functional change.
>>>
>>> Reported-by: Zeal Robot <zealci@....com.cn>
>>> Signed-off-by: Changcheng Deng <deng.changcheng@....com.cn>
>>> ---
>>>   tools/testing/selftests/powerpc/tm/tm-poison.c | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c b/tools/testing/selftests/powerpc/tm/tm-poison.c
>>> index 29e5f26..27c083a 100644
>>> --- a/tools/testing/selftests/powerpc/tm/tm-poison.c
>>> +++ b/tools/testing/selftests/powerpc/tm/tm-poison.c
>>> @@ -20,7 +20,6 @@
>>>   #include <sched.h>
>>>   #include <sys/types.h>
>>>   #include <signal.h>
>>> -#include <inttypes.h>
>>>   #include "tm.h"
>>>
>>
>> We can't accept this patch. The from and Signed-off-by don't match.
> 
> As far as I can see they match:
> 
> From: Changcheng Deng <deng.changcheng@....com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@....com.cn>
> 

Yeah. My bad.

thanks,
-- Shuah