linux-kernel - Re: [PATCH] tpm: tis: Kconfig: Add helper dependency on COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c497b3055c49733a10a25e0356090d593874e2ea.camel@kernel.org>
Date:   Thu, 26 Aug 2021 01:20:18 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Cai Huoqing <caihuoqing@...du.com>, peterhuewe@....de, jgg@...pe.ca
Cc:     linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tpm: tis: Kconfig: Add helper dependency on COMPILE_TEST

On Wed, 2021-08-25 at 14:26 +0800, Cai Huoqing wrote:
> it's helpful for complie test in other platform(e.g.X86)

You need to write a proper long description, starting from that
sentences start with capital letter and end with a period.

What is "it"?


> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
> ---
>  drivers/char/tpm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index d6ba644f6b00..4a5516406c22 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -76,7 +76,7 @@ config TCG_TIS_SPI_CR50
>  
>  config TCG_TIS_SYNQUACER
>  	tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface (MMIO - SynQuacer)"
> -	depends on ARCH_SYNQUACER
> +	depends on ARCH_SYNQUACER || COMPILE_TEST
>  	select TCG_TIS_CORE
>  	help
>  	  If you have a TPM security chip that is compliant with the

/Jarkko