linux-kernel - Re: [v3 PATCH 3/3] mm: hwpoison: dump page for unhandlable page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <32d21645-699e-09a8-9c77-67c448e1037b@redhat.com>
Date:   Wed, 25 Aug 2021 10:16:06 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Yang Shi <shy828301@...il.com>, naoya.horiguchi@....com,
        osalvador@...e.de, tdmackey@...tter.com, willy@...radead.org,
        akpm@...ux-foundation.org, corbet@....net
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [v3 PATCH 3/3] mm: hwpoison: dump page for unhandlable page

On 24.08.21 04:09, Yang Shi wrote:
> Currently just very simple message is shown for unhandlable page, e.g.
> non-LRU page, like:
> soft_offline: 0x1469f2: unknown non LRU page type 5ffff0000000000 ()
> 
> It is not very helpful for further debug, calling dump_page() could show
> more useful information.
> 
> Calling dump_page() in get_any_page() in order to not duplicate the call
> in a couple of different places.  It may be called with pcp disabled and
> holding memory hotplug lock, it should be not a big deal since hwpoison
> handler is not called very often.
> 
> Suggested-by: Matthew Wilcox <willy@...radead.org>
> Cc: Naoya Horiguchi <naoya.horiguchi@....com>
> Cc: Oscar Salvador <osalvador@...e.de>
> Signed-off-by: Yang Shi <shy828301@...il.com>
> ---
> v3: * Remove redundant pr_info per Noaya Horiguchi
> 
>   mm/memory-failure.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 7cfa134b1370..5f8249e4d7dc 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1228,6 +1228,9 @@ static int get_any_page(struct page *p, unsigned long flags)
>   		ret = -EIO;
>   	}
>   out:
> +	if (ret == -EIO)
> +		dump_page(p, "hwpoison: unhandlable page");
> +
>   	return ret;
>   }
>   
> @@ -2205,9 +2208,6 @@ int soft_offline_page(unsigned long pfn, int flags)
>   			try_again = false;
>   			goto retry;
>   		}
> -	} else if (ret == -EIO) {
> -		pr_info("%s: %#lx: unknown page type: %lx (%pGp)\n",
> -			 __func__, pfn, page->flags, &page->flags);
>   	}
>   
>   	return ret;
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb