linux-kernel - Re: [PATCH] selftests/bpf: Use kselftest skip code for skipped tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADBMgpxckMvMfOSLwcReeNCpmWmk7EETdK_AMUBY37yhA+u5CA@mail.gmail.com>
Date:   Tue, 24 Aug 2021 18:32:32 -0700
From:   Dylan Hatch <dylanbhatch@...gle.com>
To:     Po-Hsu Lin <po-hsu.lin@...onical.com>
Cc:     linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
        netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
        hawk@...nel.org, kuba@...nel.org, davem@...emloft.net,
        kpsingh@...nel.org, john.fastabend@...il.com, yhs@...com,
        songliubraving@...com, kafai@...com, andrii@...nel.org,
        daniel@...earbox.net, ast@...nel.org, skhan@...uxfoundation.org
Subject: Re: [PATCH] selftests/bpf: Use kselftest skip code for skipped tests

On Sun, Aug 22, 2021 at 8:12 PM Po-Hsu Lin <po-hsu.lin@...onical.com> wrote:
>
> There are several test cases in the bpf directory are still using
> exit 0 when they need to be skipped. Use kselftest framework skip
> code instead so it can help us to distinguish the return status.
>
> Criterion to filter out what should be fixed in bpf directory:
>   grep -r "exit 0" -B1 | grep -i skip
>
> This change might cause some false-positives if people are running
> these test scripts directly and only checking their return codes,
> which will change from 0 to 4. However I think the impact should be
> small as most of our scripts here are already using this skip code.
> And there will be no such issue if running them with the kselftest
> framework.
>
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@...onical.com>
Reviewed-By: Dylan Hatch <dylanbhatch@...gle.com>