linux-kernel - Re: [PATCH v3 4/6] staging: r8188eu: add error handling of rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3396277b-6d80-b621-0ef0-71de7d581602@gmail.com>
Date:   Wed, 25 Aug 2021 13:13:54 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        gregkh@...uxfoundation.org, straube.linux@...il.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/6] staging: r8188eu: add error handling of rtw_read16

On 8/25/21 1:06 PM, Dan Carpenter wrote:
> On Wed, Aug 25, 2021 at 12:55:37PM +0300, Pavel Skripkin wrote:
>> The main problem, that no one knows who is the "old". Greg can take patches
>> in any order he wants
> 
> Patches are always taken in first come first serve.
> 


Ok, but if pending patch needs new version, then it will be taken at the 
end?

Here is the situation we have:

	I have the patch series based on old function behavior, it was
	posted first

	Then Fabio posted refactoring of the function and it changes
	return values.


Both series are pending right now and made on top of staging-next 
branch. Who needs to rebase? I think, applying these series as-is can 
broke the driver, since error handling will be broken





With regards,
Pavel Skripkin