linux-kernel - Re: [PATCH v3] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Aug 2021 18:28:16 +0800
From:   houlong wei <houlong.wei@...iatek.com>
To:     Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
CC:     "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Alexandre Courbot" <acourbot@...omium.org>,
        "kernel@...labora.com" <kernel@...labora.com>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        "hverkuil@...all.nl" <hverkuil@...all.nl>,
        "dafna3@...il.com" <dafna3@...il.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "tfiga@...omium.org" <tfiga@...omium.org>,
        "Minghsiu Tsai (蔡明修)" 
        <Minghsiu.Tsai@...iatek.com>,
        Andrew-CT Chen (陳智迪) 
        <Andrew-CT.Chen@...iatek.com>,
        Tiffany Lin (林慧珊) 
        <tiffany.lin@...iatek.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "courbot@...omium.org" <courbot@...omium.org>,
        "hsinyi@...omium.org" <hsinyi@...omium.org>,
        "eizan@...omium.org" <eizan@...omium.org>,
        <houlong.wei@...iatek.com>
Subject: Re: [PATCH v3] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer

On Wed, 2021-08-25 at 18:17 +0800, Dafna Hirschfeld wrote:
> From: Alexandre Courbot <acourbot@...omium.org>
> 
> When running memcpy_toio:
> memcpy_toio(send_obj->share_buf, buf, len);
> it was found that errors appear if len is not a multiple of 8:
> 
> [58.350841] mtk-mdp 14001000.rdma: processing failed: -22
> 
> This patch ensures the copy of a multile of 8 size by calling
> round_up(len, 8) when copying
> 
> Fixes: e6599adfad30 ("media: mtk-vpu: avoid unaligned access to DTCM buffer.")
> Signed-off-by: Alexandre Courbot <acourbot@...omium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
> ---

Reviewed-by: Houlong Wei <houlong.wei@...iatek.com>

> changes since v2:
> 1. do the extra copy only if len is not multiple of 8
> 
> changes since v1:
> 1. change sign-off-by tags
> 2. change values to memset
> 
>  drivers/media/platform/mtk-vpu/mtk_vpu.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.c b/drivers/media/platform/mtk-vpu/mtk_vpu.c
> index ec290dde59cf..658161ee3e4e 100644
> --- a/drivers/media/platform/mtk-vpu/mtk_vpu.c
> +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c
> @@ -349,7 +349,16 @@ int vpu_ipi_send(struct platform_device *pdev,
>  		}
>  	} while (vpu_cfg_readl(vpu, HOST_TO_VPU));
>  
> -	memcpy_toio(send_obj->share_buf, buf, len);
> +	if (len % 8 != 0) {
> +		unsigned char data[SHARE_BUF_SIZE];
> +
> +		memset(data + len, 0, sizeof(data) - len);
> +		memcpy(data, buf, len);
> +		memcpy_toio(send_obj->share_buf, data, round_up(len, 8));
> +	} else {
> +		memcpy_toio(send_obj->share_buf, buf, len);
> +	}
> +
>  	writel(len, &send_obj->len);
>  	writel(id, &send_obj->id);
>