linux-kernel - Re: [PATCH] mxser: use semi-colons instead of commas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cf2ce3bc-323d-b622-214a-62cd012f29ad@kernel.org>
Date:   Wed, 25 Aug 2021 14:57:17 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mxser: use semi-colons instead of commas

On 25. 08. 21, 9:24, Dan Carpenter wrote:
> This code works, but it's cleaner to use semi-colons at the end of
> a statement instead of a comma.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Jiri Slaby <jirislaby@...nel.org>

> ---
>   drivers/tty/mxser.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
> index 335e4e50d679..1216f3985e18 100644
> --- a/drivers/tty/mxser.c
> +++ b/drivers/tty/mxser.c
> @@ -1039,12 +1039,12 @@ static int mxser_get_serial_info(struct tty_struct *tty,
>   	if (closing_wait != ASYNC_CLOSING_WAIT_NONE)
>   		closing_wait = jiffies_to_msecs(closing_wait) / 10;
>   
> -	ss->type = info->type,
> -	ss->line = tty->index,
> -	ss->port = info->ioaddr,
> -	ss->irq = info->board->irq,
> -	ss->flags = info->port.flags,
> -	ss->baud_base = MXSER_BAUD_BASE,
> +	ss->type = info->type;
> +	ss->line = tty->index;
> +	ss->port = info->ioaddr;
> +	ss->irq = info->board->irq;
> +	ss->flags = info->port.flags;
> +	ss->baud_base = MXSER_BAUD_BASE;
>   	ss->close_delay = close_delay;
>   	ss->closing_wait = closing_wait;
>   	ss->custom_divisor = MXSER_CUSTOM_DIVISOR,
> 


-- 
js
suse labs