linux-kernel - Re: [PATCH] tty: moxa: use semi-colons instead of commas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 25 Aug 2021 16:22:26 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] tty: moxa: use semi-colons instead of commas

On Wed, Aug 25, 2021 at 02:58:19PM +0200, Jiri Slaby wrote:
> On 25. 08. 21, 9:24, Dan Carpenter wrote:
> > This code works but it's cleaner to use a semi-colon to end a statement
> > instead of a comma.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> Acked-by: Jiri Slaby <jirislaby@...nel.org>
> 
> I just wonder why:
>   tty: moxa:
> vs
>   mxser:
> with no "tty: "
> ...

Now I'm confused.  There is a different mxser driver, but this is
modifying moxa?  I just copied from git log --oneline drivers/tty/moxa.c.

regards,
dan carpenter


> 
> > ---
> >   drivers/tty/moxa.c | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
> > index 776f78de0f82..bf17e90858b8 100644
> > --- a/drivers/tty/moxa.c
> > +++ b/drivers/tty/moxa.c
> > @@ -2034,10 +2034,10 @@ static int moxa_get_serial_info(struct tty_struct *tty,
> >   	if (!info)
> >   		return -ENODEV;
> >   	mutex_lock(&info->port.mutex);
> > -	ss->type = info->type,
> > -	ss->line = info->port.tty->index,
> > -	ss->flags = info->port.flags,
> > -	ss->baud_base = 921600,
> > +	ss->type = info->type;
> > +	ss->line = info->port.tty->index;
> > +	ss->flags = info->port.flags;
> > +	ss->baud_base = 921600;
> >   	ss->close_delay = jiffies_to_msecs(info->port.close_delay) / 10;
> >   	mutex_unlock(&info->port.mutex);
> >   	return 0;
> > 
> 
> 
> -- 
> js
> suse labs