linux-kernel - Re: [PATCH v3 3/3] PCI/MSI: remove msi_attrib.default_irq in msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bl5lpru9.wl-maz@kernel.org>
Date:   Wed, 25 Aug 2021 14:38:22 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Barry Song <21cnbao@...il.com>
Cc:     bhelgaas@...gle.com, tglx@...utronix.de,
        Jonathan.Cameron@...wei.com, bilbao@...edu, corbet@....net,
        gregkh@...uxfoundation.org, leon@...nel.org,
        linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
        linuxarm@...wei.com, luzmaximilian@...il.com,
        mchehab+huawei@...nel.org, schnelle@...ux.ibm.com,
        jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
        intel-wired-lan@...ts.osuosl.org,
        Barry Song <song.bao.hua@...ilicon.com>
Subject: Re: [PATCH v3 3/3] PCI/MSI: remove msi_attrib.default_irq in msi_desc

On Wed, 25 Aug 2021 11:26:36 +0100,
Barry Song <21cnbao@...il.com> wrote:
> 
> From: Marc Zyngier <maz@...nel.org>
> 
> default_irq is hideous as it should be per-device but not per-desc.
> On the other hand, MSI-X case doesn't use it at all. Since sysfs
> IRQ has moved to use the msi_entry instead of pci_dev.irq, now it
> seems it is safe to remove msi_attrib.default_irq.

Thanks for doing the write-up. Maybe worth adding that drivers that
use dev->irq while having enabled MSI will break (INTx will be
disabled while MSI is enabled). That should give people a clue about
what to fix when they bisect the problem to this patch.

Also, a link to the discussion that lead to this patch would be useful
to give some context.

No need to respin this for now, let's give it a shake after 5.14.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.