linux-kernel - Re: [PATCH] selftests/net: Use kselftest skip code for skipped tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 25 Aug 2021 11:21:13 +0800
From:   Po-Hsu Lin <po-hsu.lin@...onical.com>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        linux-kselftest@...r.kernel.org, netdev@...r.kernel.org,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Shuah Khan <skhan@...uxfoundation.org>, petrm@...dia.co,
        oleksandr.mazur@...ision.eu, idosch@...dia.com, jiri@...dia.com,
        nikolay@...dia.com, gnault@...hat.com, simon.horman@...ronome.com,
        baowen.zheng@...igine.com, danieller@...dia.com
Subject: Re: [PATCH] selftests/net: Use kselftest skip code for skipped tests

On Tue, Aug 24, 2021 at 3:24 PM Ido Schimmel <idosch@...sch.org> wrote:
>
> On Mon, Aug 23, 2021 at 04:58:54PM +0800, Po-Hsu Lin wrote:
> > There are several test cases in the net directory are still using
> > exit 0 or exit 1 when they need to be skipped. Use kselftest
> > framework skip code instead so it can help us to distinguish the
> > return status.
> >
> > Criterion to filter out what should be fixed in net directory:
> >   grep -r "exit [01]" -B1 | grep -i skip
> >
> > This change might cause some false-positives if people are running
> > these test scripts directly and only checking their return codes,
> > which will change from 0 to 4. However I think the impact should be
> > small as most of our scripts here are already using this skip code.
> > And there will be no such issue if running them with the kselftest
> > framework.
> >
> > Signed-off-by: Po-Hsu Lin <po-hsu.lin@...onical.com>
>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> Tested-by: Ido Schimmel <idosch@...dia.com>

Thank you for the test and the review!
PHLin