linux-kernel - Re: [PATCH v2] ARM: dts: da850-evm: Change aemif node status from "ok" to "okay"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210825161502.ap2clalwfljezoqk@perfume>
Date:   Wed, 25 Aug 2021 11:15:02 -0500
From:   Nishanth Menon <nm@...com>
To:     Roger Quadros <rogerq@...nel.org>
CC:     <nsekhar@...com>, <bgolaszewski@...libre.com>,
        <lokeshvutla@...com>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: da850-evm: Change aemif node status from
 "ok" to "okay"

On 13:55-20210824, Roger Quadros wrote:
> As per Device Tree Specification [1], the status parameter of nodes can
> be "okay", "disabled", etc. "ok" is not a valid parameter.
> 
> U-boot Driver Model does not recognize status="ok" either and treats
> the node as disabled.

^^ the above comment might be fine to indicate the side effect of
non-compliance

> 
> [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
> 
> Signed-off-by: Roger Quadros <rogerq@...nel.org>

Reviewed-by: Nishanth Menon <nm@...com>

> ---
> Changelog:
> v2
> -refer to DT spec instead of schema in commit log.
> 
>  arch/arm/boot/dts/da850-evm.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
> index 87c517d65f62..9dc79b5977bf 100644
> --- a/arch/arm/boot/dts/da850-evm.dts
> +++ b/arch/arm/boot/dts/da850-evm.dts
> @@ -415,7 +415,7 @@
>  &aemif {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&nand_pins>;
> -	status = "ok";
> +	status = "okay";
>  	cs3 {
>  		#address-cells = <2>;
>  		#size-cells = <1>;
> -- 
> 2.17.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D